From 91e80cc4a4b48b031b65a5cd4024ed5b113c131f Mon Sep 17 00:00:00 2001 From: Haim Ashkenazi Date: Sat, 3 Mar 2018 20:34:00 +0200 Subject: [PATCH] zsh-completion: remove bad test I thought there was a bug in the boolSlice definition but it seems It was my mistake in identifying what's going on. Also removed the provisioning to skip tests (doesn't seem to be needed anymore). --- zsh_completions_test.go | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/zsh_completions_test.go b/zsh_completions_test.go index c5199ed..c4e1a95 100644 --- a/zsh_completions_test.go +++ b/zsh_completions_test.go @@ -15,7 +15,6 @@ func TestGenZshCompletion(t *testing.T) { name string root *Command expectedExpressions []string - skip string }{ { name: "simple command", @@ -112,18 +111,6 @@ func TestGenZshCompletion(t *testing.T) { `'\(\*-d \*--debug\)'{\\\*-d,\\\*--debug}`, }, }, - { - name: "boolSlice should not accept arguments", - root: func() *Command { - r := genTestCommand("mycmd", true) - r.Flags().BoolSlice("verbose", []bool{}, "verbosity level") - return r - }(), - expectedExpressions: []string{ - `'\*--verbose\[verbosity level]'`, - }, - skip: "BoolSlice behaves strangely both with NoOptDefVal and type (identifies as bool)", - }, } for _, tc := range tcs { @@ -135,10 +122,6 @@ func TestGenZshCompletion(t *testing.T) { } output := buf.Bytes() - if tc.skip != "" { - t.Skip("Skipping:", tc.skip) - } - for _, expr := range tc.expectedExpressions { rgx, err := regexp.Compile(expr) if err != nil {