87a016c909
Bump github.com/prometheus/procfs from 0.11.1 to 0.12.0
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.11.1 to 0.12.0.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.11.1...v0.12.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-10-04 14:51:07 +00:00
7004b66eda
Bump golang.org/x/sys from 0.11.0 to 0.12.0
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.11.0 to 0.12.0.
- [Commits](https://github.com/golang/sys/compare/v0.11.0...v0.12.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-10-04 14:47:05 +00:00
df7fa49417
Extend Counters, Summaries and Histograms with creation timestamp ( #1313 )
...
* Extend Counters, Summaries and Histograms with creation timestamp
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
* Backport created timestamp to existing tests
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
* Last touches (readability and consistency)
Changes:
* Comments for "now" are more explicit and not inlined.
* populateMetrics is simpler and bit more efficient without timestamp to time to timestamp conversionts for more common code.
* Test consistency and simplicity - the fewer variables the better.
* Fixed inconsistency for v2 and MetricVec - let's pass opt.now consistently.
* We don't need TestCounterXXXTimestamp - we test CT in many other places already.
* Added more involved test for counter vectors with created timestamp.
* Refactored normalization for simplicity.
* Make histogram, summaries now consistent.
* Simplified histograms CT flow and implemented proper CT on reset.
TODO for next PRs:
* NewConstSummary and NewConstHistogram - ability to specify CTs there.
Signed-off-by: bwplotka <bwplotka@gmail.com>
* Update prometheus/counter_test.go
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
---------
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Signed-off-by: bwplotka <bwplotka@gmail.com>
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
Co-authored-by: bwplotka <bwplotka@gmail.com>
2023-09-21 10:46:54 +01:00
8483c5dab8
Bump google.golang.org/protobuf from 1.30.0 to 1.31.0
...
Bumps google.golang.org/protobuf from 1.30.0 to 1.31.0.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-08-14 14:54:09 +00:00
85f4592a0c
Bump github.com/prometheus/common from 0.42.0 to 0.44.0
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.42.0 to 0.44.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.42.0...v0.44.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-08-14 13:46:29 +00:00
f215f759c6
Bump golang.org/x/sys from 0.10.0 to 0.11.0
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.10.0 to 0.11.0.
- [Commits](https://github.com/golang/sys/compare/v0.10.0...v0.11.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-08-14 13:30:38 +00:00
4abd83d655
Update building ( #1326 )
...
* Remove unused / non-standard .go-version.
* Cleanup indenting in Makefile.
* Enable dependabot for subdirs.
* Update golanci-lint CI.
* Update go.mod version directives to match supported versions.
* Disable golanci-lint unused-parameter.
Signed-off-by: SuperQ <superq@gmail.com>
2023-08-14 15:29:51 +02:00
1a88780343
Bump prometheus/client_model ( #1323 )
...
By upgrading prometheus/client_model, several test functions had to be re-written due to 2 breaking changes made in protobuf when parsing messages to text:
1. '<' and '>' characters were replaced with '{' and '}' respectively.
2. The text format is non-deterministic. More information in https://github.com/golang/protobuf/issues/1121
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
2023-08-11 20:17:55 +01:00
e6d9092baf
Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 ( #1319 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.11.0 to 0.11.1.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.11.0...v0.11.1 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 18:56:09 +01:00
99e905a3d5
Bump golang.org/x/sys from 0.9.0 to 0.10.0 ( #1320 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.9.0 to 0.10.0.
- [Commits](https://github.com/golang/sys/compare/v0.9.0...v0.10.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-08-01 17:12:04 +01:00
6e3b962584
Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 ( #1305 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.10.1 to 0.11.0.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.10.1...v0.11.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-26 12:53:49 +01:00
3b6fb7aa3f
Bump golang.org/x/sys from 0.8.0 to 0.9.0 ( #1306 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.8.0 to 0.9.0.
- [Commits](https://github.com/golang/sys/compare/v0.8.0...v0.9.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-07-26 12:46:32 +01:00
8840afcfc2
Bump github.com/prometheus/procfs from 0.9.0 to 0.10.1 ( #1283 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.9.0 to 0.10.1.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.9.0...v0.10.1 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-06-07 08:12:43 +01:00
8a51463540
Cleanup proto use in tests ( #1264 )
...
Switch tests over to new proto libary, eliminating the direct dependency
on the old proto library. Note the indirect requirement is still needed
due to upstream use by the client_model package.
Related: https://github.com/prometheus/client_golang/issues/1175
Signed-off-by: SuperQ <superq@gmail.com>
2023-05-03 09:46:41 +01:00
0ae00134d8
Bump golang.org/x/sys from 0.6.0 to 0.7.0 ( #1265 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/golang/sys/releases )
- [Commits](https://github.com/golang/sys/compare/v0.6.0...v0.7.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-05-03 09:45:35 +01:00
bba12b5514
Bump github.com/prometheus/common from 0.41.0 to 0.42.0 ( #1244 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.41.0 to 0.42.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.41.0...v0.42.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:57:59 +01:00
9015fcfc2c
Bump github.com/golang/protobuf from 1.5.2 to 1.5.3 ( #1245 )
...
Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf ) from 1.5.2 to 1.5.3.
- [Release notes](https://github.com/golang/protobuf/releases )
- [Commits](https://github.com/golang/protobuf/compare/v1.5.2...v1.5.3 )
---
updated-dependencies:
- dependency-name: github.com/golang/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:57:49 +01:00
1bb8cf8306
Bump golang.org/x/sys from 0.5.0 to 0.6.0 ( #1246 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/golang/sys/releases )
- [Commits](https://github.com/golang/sys/compare/v0.5.0...v0.6.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-04-13 10:41:40 +01:00
852a282f10
Bump google.golang.org/protobuf from 1.28.1 to 1.30.0
...
Bumps google.golang.org/protobuf from 1.28.1 to 1.30.0.
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-04-01 09:58:51 +00:00
2236d782ff
api: Extend and improve json-iterator usage
...
For one, this pulls up the histogram-related json-iterator usage from
prometheus/common into the API client. Previously, the only
json-iterater usage was here in the API client. But then json-iterator
was used for the native histogram additions directly in
prometheus/common, see
https://github.com/prometheus/common/pull/440/files . This however
meant that any user of prometheus/common/model would now link in
json-iterator, even if they are not using the JSON marshaling at
all. To keep prometheus/common/model more leightweight, this commit
moves all the json-iterator usage into the API client itself, as it
was done before for the normal float samples.
This commit also adds an unmarshaling function for native histograms,
which didn't even exist in prometheus/common/model so far.
It also adds json-iterator marshaling and un-marshaling for
model.SampleStream, which is only needed for the benchmark
(BenchmarkSamplesJsonSerialization). This fixes the benchmark such
that it actually compares json-iterator and std-lib json encoding
(which didn't work before because the custom marshaling methods of
model.SampleStream enforced std-lib json encoding for floats and
json-iterator encoding for histograms in all cases).
I expect this to fix #1179 .
Signed-off-by: beorn7 <beorn@grafana.com>
2023-03-01 17:27:33 +01:00
2fced96110
Bump github.com/prometheus/common from 0.37.0 to 0.39.0 ( #1197 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.37.0 to 0.39.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.37.0...v0.39.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-01 14:28:26 +01:00
b8b41c85ae
Bump golang.org/x/sys from 0.3.0 to 0.4.0 ( #1217 )
...
Bumps [golang.org/x/sys](https://github.com/golang/sys ) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/golang/sys/releases )
- [Commits](https://github.com/golang/sys/compare/v0.3.0...v0.4.0 )
---
updated-dependencies:
- dependency-name: golang.org/x/sys
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-02-01 12:04:45 +01:00
d5a9239503
Merge pull request #1198 from prometheus/dependabot/go_modules/github.com/prometheus/procfs-0.9.0
...
Bump github.com/prometheus/procfs from 0.8.0 to 0.9.0
2023-01-25 14:37:42 +01:00
14aa20358b
Bump github.com/cespare/xxhash/v2 from 2.1.2 to 2.2.0
...
Bumps [github.com/cespare/xxhash/v2](https://github.com/cespare/xxhash ) from 2.1.2 to 2.2.0.
- [Release notes](https://github.com/cespare/xxhash/releases )
- [Commits](https://github.com/cespare/xxhash/compare/v2.1.2...v2.2.0 )
---
updated-dependencies:
- dependency-name: github.com/cespare/xxhash/v2
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-01 09:02:31 +00:00
26620fdd58
Bump github.com/prometheus/procfs from 0.8.0 to 0.9.0
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.8.0 to 0.9.0.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.8.0...v0.9.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-01-01 09:02:21 +00:00
27f0506d6e
Bump golang.org/x/text to v0.3.8 to mitigate CVE-2022-32149 ( #1187 )
...
Signed-off-by: Alex Goncharov <github@b4bay.com>
Signed-off-by: Alex Goncharov <github@b4bay.com>
2022-12-22 16:14:44 +01:00
4e71e6ff20
Update prometheus/client_model dependency
...
Native histograms are now in a tagged version (v0.3.0).
Signed-off-by: beorn7 <beorn@grafana.com>
2022-10-19 18:27:50 +02:00
95cf173f19
Merge branch 'main' into sparsehistogram
2022-08-23 14:28:33 +02:00
c6d4e40244
Bump github.com/prometheus/procfs from 0.7.3 to 0.8.0 ( #1097 )
...
Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs ) from 0.7.3 to 0.8.0.
- [Release notes](https://github.com/prometheus/procfs/releases )
- [Commits](https://github.com/prometheus/procfs/compare/v0.7.3...v0.8.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/procfs
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-02 10:43:54 +02:00
76cdae298e
Bump google.golang.org/protobuf from 1.28.0 to 1.28.1 ( #1099 )
...
Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go ) from 1.28.0 to 1.28.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases )
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash )
- [Commits](https://github.com/protocolbuffers/protobuf-go/compare/v1.28.0...v1.28.1 )
---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-02 10:24:34 +02:00
9154d30db7
Bump github.com/prometheus/common from 0.35.0 to 0.37.0 ( #1098 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.35.0 to 0.37.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.35.0...v0.37.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-02 10:23:53 +02:00
8cbcd4076a
histograms: Move to new exposition protobuf format
...
Note that this is an incompatible change. To scrape this new format,
the Prometheus server needs to be updated at the same time. PR
incoming.
Signed-off-by: beorn7 <beorn@grafana.com>
2022-07-19 16:54:05 +02:00
525d042127
Merge branch 'main' into sparsehistogram
2022-07-06 16:09:36 +02:00
e8f91604d8
Bump github.com/prometheus/common from 0.34.0 to 0.35.0 ( #1076 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.34.0 to 0.35.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.34.0...v0.35.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-07-04 10:31:16 +02:00
6ba7871ebb
Merge branch 'main' into sparsehistogram
2022-06-20 16:50:03 +05:30
e38d614cd6
Update minimum supported Go version ( #1062 )
...
Update minimum supported Go to 1.17 to support new module format.
Signed-off-by: SuperQ <superq@gmail.com>
2022-06-05 10:01:13 +02:00
b2372302ca
Merge branch 'main' into sparsehistogram
2022-05-15 14:16:16 +02:00
fab6748c34
Bump github.com/prometheus/common from 0.33.0 to 0.34.0 ( #1051 )
...
Bumps [github.com/prometheus/common](https://github.com/prometheus/common ) from 0.33.0 to 0.34.0.
- [Release notes](https://github.com/prometheus/common/releases )
- [Commits](https://github.com/prometheus/common/compare/v0.33.0...v0.34.0 )
---
updated-dependencies:
- dependency-name: github.com/prometheus/common
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-05-13 10:20:41 +02:00
cd90f33be8
smart diff to testutil.GatherAndCompare ( #998 )
...
* added smart diff to testutil.GatherAndCompare
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* v2 testuitls added for better diff
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* replaced CollectAndCompare to CollectAndCompareV2 in testutil_test
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* renamed methods from v2 to withT
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* replaced testify with custom diff func
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* difflib GetUnifiedDiffString added with test
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* license meta data added to file
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
* moved difflib to internal
Signed-off-by: Sourik Ghosh <sourikghosh31@gmail.com>
2022-04-13 18:38:05 +01:00
0c691ed35f
go.mod: Exclude prometheus/client_golang v1.12.1 ( #1027 )
...
See also https://github.com/prometheus/client_golang/issues/1012
As suggested in https://github.com/prometheus/client_golang/issues/1012#issuecomment-1090482644
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
2022-04-13 18:35:14 +01:00
46d3dd4e6c
Bump minimum required Go version to 1.16 ( #1032 )
...
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
2022-04-13 16:21:42 +01:00
29e8191aff
go.mod: Update dependencies ( #1018 )
...
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
2022-03-29 14:15:42 +01:00
294cca4252
Merge branch 'main' into sparsehistogram
2022-02-02 16:07:09 +01:00
5678ca5ed1
go.mod: Set minimal support version of go to 1.15
...
As requested in https://github.com/prometheus/common/pull/353#discussion_r793113705
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
2022-01-31 11:03:13 +01:00
5bd9ee52dc
go.*: Update dependencies ( #965 )
...
* Update dependencies
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
* Update deprecated APIs
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
* Add missing dependency explicitly
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
2022-01-18 20:32:44 +01:00
5b19c553c3
Merge branch 'master' into sparsehistogram
2022-01-11 14:01:38 +01:00
679eb0d315
Update cespare/xxhash dependency ( #913 )
...
Brings in a fix for asm errors when dynamic linking with Go 1.17.
Fixes #912
Signed-off-by: David Trudgian <david.trudgian@sylabs.io>
2021-09-29 11:11:17 +01:00
84fcafffb1
Merge branch 'master' into sparsehistogram
2021-08-18 16:41:04 +02:00
514234486b
Pin client_model to the most recent sparsehistogram commit
...
Signed-off-by: beorn7 <beorn@grafana.com>
2021-06-24 22:12:46 +02:00
31318b7523
Switch to base-2 buckets
...
This seem what OTel is converging towards, see
https://github.com/open-telemetry/oteps/pull/149 .
I see pros and cons with base-10 vs base-2. They are discussed in
detail in that OTel PR, and the gist of the discussion is pretty much
in line with my design doc. Since the balance is easy to tip here, I
think we should go with base-2 if OTel picks base-2. This also seems
to be in agreement with several proprietary solution (see again the
discussion on that OTel PR.)
The idea to make the number of buckets per power of 2 (or formerly 10)
a power of 2 itself was also sketched out in the design doc
already. It guarantees mergeability of different resolutions. I was
undecided between making it a recommendation or mandatory. Now I think
it should be mandatory as it has the additional benefit of playing
well with OTel's plans.
This commit also addresses a number of outstanding TODOs.
Signed-off-by: beorn7 <beorn@grafana.com>
2021-06-23 16:48:03 +02:00
dependabot[bot]