35559538c7
Implements review commentary
...
Specifically @beorn7 pointed out that the previous implementation had
some shortcomings around large numbers. I've changed the code to match
the suggestion in review, as well as added a few test cases.
2017-12-15 11:03:30 -08:00
ae6939214c
Adds a faster counter
2017-12-15 11:03:24 -08:00
9f5d03c01f
Fix typo in comment
2017-10-04 17:44:49 +01:00
50b3332fd6
Polishing some doc comments
2017-09-13 12:48:29 +02:00
77a1417b06
Change summary docs
2017-09-12 20:27:18 +03:00
b092a4bc11
Correct DefaultRegistry to DefaultRegisterer
...
`DefaultRegistry` no longer exists as of a6321dd0b
2017-09-05 01:08:40 +01:00
2cb8df16e3
Fix error reporting bug
...
That's the same bug fixed in #342 (which is the deprecated code only
replicated in the `prometheus` package until v0.10 is out).
2017-08-31 15:10:58 +02:00
a166207919
http.go: incorrect error message displayed when no metrics encoded error
...
The "No metrics encoded" error was erroneously displayed the value of err, not
lastErr.
2017-08-31 12:05:46 +10:00
6164fff8ce
Remove the deprecated uses of Untyped metrics
...
I couldn't find any use of the removed identifiers on sourcegraph.com
(outside of this repo itself).
2017-08-29 17:31:45 +02:00
be904beebc
fix spelling typo
2017-08-28 08:57:51 +08:00
a956c5fdd6
improve validation function naming
2017-08-25 17:58:59 +02:00
0b8aef084e
implement review feedback
2017-08-25 14:51:19 +02:00
6df742e132
improve formatting of invalid label value error messages
2017-08-20 00:54:11 +02:00
555018f3c9
make code compatible with go 1.6
2017-08-20 00:53:55 +02:00
685a3c90d4
fail Gather'ing when label value is not utf8
2017-08-20 00:10:32 +02:00
7ee20d77cb
validate ConstLabels values in NewDesc
2017-08-20 00:09:51 +02:00
703c4a9c6f
add label value validation to NewConstMetric and friends
2017-08-20 00:09:51 +02:00
459e88167e
extract and refactor label validation functions
...
so that we can reuse them in other parts of the code, not only as part
of a metricVec.
2017-08-20 00:09:50 +02:00
957bba6f68
add label value validation to GetMetricWith and friends
2017-08-19 22:55:41 +02:00
f36d4a3e73
Add new default metric go_info
2017-07-23 23:36:09 +02:00
ed379b7d99
Remove remaining references to MetricVec from doc comments
...
MetricVec is un-experted by now. godoc handles that correctly by
showing the methods of the embedded un-exported metricVec with the
exported type (CounterVec, SummaryVec, ...) that embeds metricVec.
2017-07-12 15:13:09 +02:00
90494ea7b1
fix typo in comments
...
Signed-off-by: Maxime Song <me@cppdo.com>
2017-07-07 23:28:24 +08:00
310ce84375
Merge pull request #319 from prometheus/beorn7/vec
...
Unexport MetricVec
2017-06-30 16:48:34 +02:00
e04de4bfe3
Document the use of Go1.9+ for monotonic time where applicable
2017-06-29 16:07:12 +02:00
f66cdf0736
Un-export MetricVec
...
This is in preparation for "curried" metric vecs, as discussed.
And it's a good thing anyway. The exported MetricVec was from a time
when I thought people would define own Metric types and then create
Vecs of it. That has never happened.
2017-06-28 17:55:59 +02:00
721f93fda8
Deprecate UntypedVec
2017-06-28 17:00:33 +02:00
f0c4c478a2
Minor documentation fix
2017-06-28 15:40:03 +03:00
14730c70c0
promhttp: Bite the bullet and implement all 32 possible interface combos
...
As it turned out, it's not that esay to guess "common" combination of
interface upgrades. So I decided to just implement all 32 possible
combination of interface upgrades. (Only 16 with Go 1.7 and earlier.)
Clearly, this calls for code generation. But right now, we still need
to find out what's the best form of the code. For later additions,
implementing code generation might be useful.
Note that newDelegator is called for each HTTP request. Thus, this
commit aims to make the upgrade selection quick. (After the type
checks, it's just directly accessing an element in a slice.)
2017-06-02 19:03:08 +02:00
e7e903064f
Import "log", it is required for log.Fatal(... ( #305 )
...
Import "log" in the example doc comment
Package log is required for log.Fatal.
2017-05-31 15:00:54 +02:00
2b3ab50dcd
Add time to write header handler middleware ( #304 )
2017-05-29 11:42:43 +02:00
023c31fd59
Fix handling of ConstLabels in checkLabels
2017-05-10 20:39:36 +02:00
753a259e20
Improve promhttp tests
...
- Use local registry to avoid conflicts between tests.
- Expose https://github.com/prometheus/client_golang/issues/299 by
using ConstLabels in a test.
- Improve example: Buckets and help string must be consistent, even
if the former is not enforced as of now, but see
https://github.com/prometheus/client_golang/issues/222
2017-05-10 19:49:36 +02:00
4ea620c5bf
Point to promhttp in deprecation notices
2017-05-09 18:54:33 +02:00
d300d5cf21
Instrument RoundTripper via middleware ( #295 )
...
Instrument RoundTripper via middleware
2017-05-09 18:46:09 +02:00
d01fd62222
new handler instrumentation ( #285 )
...
Add new HTTP handler instrumentation
2017-04-24 15:13:19 -04:00
08fd2e1237
Merge pull request #281 from adjust/add_gc_cpu_fraction
...
Adding GCCPUFraction metric to goCollector
2017-04-01 12:34:46 +02:00
6d619ff5a8
Fix typo
2017-03-22 21:29:18 +08:00
bea9149ebb
Fix typo
2017-03-07 16:11:13 +02:00
ae77d82d88
Fix invalid Timer (gauge) example
...
The example method is assumed to be used as main() function. As a main()
function doesn't have any return values, the example doesn't compile and
is invalid.
2017-02-28 11:13:17 -04:00
69bb387064
Fix typo
2017-02-23 10:28:41 +01:00
56cf0be13f
Adding GCCPUFraction metric to goCollector
2017-02-22 17:26:08 +01:00
70693bc297
Document graphite bridge
2017-02-15 12:19:46 -04:00
efb2f142f3
goCollector: change goroutines and treads type
...
Change gorountines and threads created Gauge to NewConstMetric.
Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
2017-02-15 13:06:22 +08:00
fa1cd67d1e
goCollector: add thread count gauge in goCollector
...
Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
2017-02-13 19:39:00 +08:00
9fdd167dba
InstrumentHandler: Document issues with HTTP/2
2017-01-25 12:49:31 +01:00
60e61927fc
graphite: Adjust ExtractSamples call to new interface
2017-01-08 20:55:34 +01:00
575f371f78
Merge pull request #262 from prometheus/beorn7/summary
...
Allow Summaries with empty objectives and deprecate DefObjectives
2016-11-24 16:57:32 +01:00
e83345f73f
Merge pull request #250 from prometheus/timer-helper
...
Add timer helper function
2016-11-23 18:45:33 +01:00
9c4b7780d7
Allow Summaries with empty objectives and deprecate DefObjectives
...
This also updates all tests and examples to use explicitly set
objectives.
In v0.10, DefObjectives will be completely removed, and the default
Summary will have no objectives then.
Fixes #118
2016-11-23 18:35:02 +01:00
6bff9dc5a4
Make heap_released_bytes a Gauge.
...
It's not a counter after all.
Also, remove a misleading part of the sys_bytes help string.
2016-11-22 18:11:47 +01:00
Stephen McQuay (smcquay)