mirror
/
client_golang
mirror of https://github.com/prometheus/client_golang.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Attempt to fix flakiness of TestGoCollectorMemStats 

This is really lame as it essentially just uses longer times to
wait. The test is still timing-dependent and thus could still
theoretically fail with unlucky scheduling. However, we are testing
something that _is_ about timing. Turning this all into something not
timing-dependent would be first quite involved and second might defeat
the purpose of testing code that is inherently about timing.

Let's see how this works out in practice.

Signed-off-by: beorn7 <bjoern@rabenste.in>
This commit is contained in:
beorn7 2019-05-26 13:25:59 +02:00
parent b46e6ec51b
commit fe90eea9bb
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
prometheus/go_collector_test.go
View File

@ -184,14 +184,14 @@ func TestGoCollectorMemStats(t *testing.T) {
} }
} }
// Speed up the timing to make the tast faster. // Speed up the timing to make the test faster.
c.msMaxWait = time.Millisecond c.msMaxWait = 5 * time.Millisecond
c.msMaxAge = 10 * time.Millisecond c.msMaxAge = 50 * time.Millisecond
// Scenario 1: msRead responds slowly, no previous memstats available, // Scenario 1: msRead responds slowly, no previous memstats available,
// msRead is executed anyway. // msRead is executed anyway.
c.msRead = func(ms *runtime.MemStats) { c.msRead = func(ms *runtime.MemStats) {
time.Sleep(3 * time.Millisecond) time.Sleep(20 * time.Millisecond)
ms.Alloc = 1 ms.Alloc = 1
} }
checkCollect(1) checkCollect(1)
@ -218,12 +218,12 @@ func TestGoCollectorMemStats(t *testing.T) {
// Scenario 3: msRead responds slowly, previous memstats available, old // Scenario 3: msRead responds slowly, previous memstats available, old
// value collected. // value collected.
c.msRead = func(ms *runtime.MemStats) { c.msRead = func(ms *runtime.MemStats) {
time.Sleep(3 * time.Millisecond) time.Sleep(20 * time.Millisecond)
ms.Alloc = 3 ms.Alloc = 3
} }
checkCollect(2) checkCollect(2)
// After waiting, new value is still set in msLast. // After waiting, new value is still set in msLast.
time.Sleep(12 * time.Millisecond) time.Sleep(80 * time.Millisecond)
c.msMtx.Lock() c.msMtx.Lock()
if want, got := uint64(3), c.msLast.Alloc; want != got { if want, got := uint64(3), c.msLast.Alloc; want != got {
t.Errorf("unexpected of msLast.Alloc, want %d, got %d", want, got) t.Errorf("unexpected of msLast.Alloc, want %d, got %d", want, got)
@ -233,7 +233,7 @@ func TestGoCollectorMemStats(t *testing.T) {
// Scenario 4: msRead responds slowly, previous memstats is too old, new // Scenario 4: msRead responds slowly, previous memstats is too old, new
// value collected. // value collected.
c.msRead = func(ms *runtime.MemStats) { c.msRead = func(ms *runtime.MemStats) {
time.Sleep(3 * time.Millisecond) time.Sleep(20 * time.Millisecond)
ms.Alloc = 4 ms.Alloc = 4
} }
checkCollect(4) checkCollect(4)