mirror
/
client_golang
mirror of https://github.com/prometheus/client_golang.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

improved code more clean (#1511) 

* improved code more clean

Signed-off-by: chuanshuo <lilijreey@126.com>

* improved code more clean

Signed-off-by: chuanshuo <lilijreey@126.com>

---------

Signed-off-by: chuanshuo <lilijreey@126.com>
This commit is contained in:
chuanshuo 2024-05-09 17:34:07 +08:00 committed by GitHub
parent 853c5de11e
commit ccf82b1854
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
prometheus/registry.go
View File

@ -314,17 +314,18 @@ func (r *Registry) Register(c Collector) error {
if dimHash != desc.dimHash { if dimHash != desc.dimHash {
return fmt.Errorf("a previously registered descriptor with the same fully-qualified name as %s has different label names or a different help string", desc) return fmt.Errorf("a previously registered descriptor with the same fully-qualified name as %s has different label names or a different help string", desc)
} }
} else { continue
}
// ...then check the new descriptors already seen. // ...then check the new descriptors already seen.
if dimHash, exists := newDimHashesByName[desc.fqName]; exists { if dimHash, exists := newDimHashesByName[desc.fqName]; exists {
if dimHash != desc.dimHash { if dimHash != desc.dimHash {
return fmt.Errorf("descriptors reported by collector have inconsistent label names or help strings for the same fully-qualified name, offender is %s", desc) return fmt.Errorf("descriptors reported by collector have inconsistent label names or help strings for the same fully-qualified name, offender is %s", desc)
} }
} else { continue
}
newDimHashesByName[desc.fqName] = desc.dimHash newDimHashesByName[desc.fqName] = desc.dimHash
} }
}
}
// A Collector yielding no Desc at all is considered unchecked. // A Collector yielding no Desc at all is considered unchecked.
if len(newDescIDs) == 0 { if len(newDescIDs) == 0 {
r.uncheckedCollectors = append(r.uncheckedCollectors, c) r.uncheckedCollectors = append(r.uncheckedCollectors, c)