Merge pull request #784 from hummerd/master

Remove reference to Metric after reslicing
2020-07-25 00:01:35 +02:00 · 2020-07-25 00:01:35 +02:00 · c650ae9fa1
parent 77b35d0377 0c48254b62
commit c650ae9fa1
1 changed files with 4 additions and 0 deletions
--- a/prometheus/vec.go
+++ b/prometheus/vec.go
@ -276,7 +276,9 @@ func (m *metricMap) deleteByHashWithLabelValues(
 	}

 	if len(metrics) > 1 {
+		old := metrics
 		m.metrics[h] = append(metrics[:i], metrics[i+1:]...)
+		old[len(old)-1] = metricWithLabelValues{}
 	} else {
 		delete(m.metrics, h)
 	}
@ -302,7 +304,9 @@ func (m *metricMap) deleteByHashWithLabels(
 	}

 	if len(metrics) > 1 {
+		old := metrics
 		m.metrics[h] = append(metrics[:i], metrics[i+1:]...)
+		old[len(old)-1] = metricWithLabelValues{}
 	} else {
 		delete(m.metrics, h)
 	}