mirror
/
client_golang
mirror of https://github.com/prometheus/client_golang.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #79 from prometheus/beorn7/histogram 

Use binary search to pick bucket.
This commit is contained in:
Björn Rabenstein 2015-02-20 15:54:51 +01:00
parent 38dbb2e268 79efd06178
commit bc1f2b27ad
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
prometheus/histogram.go
View File

@ -17,6 +17,7 @@ import (
"fmt" "fmt"
"hash/fnv" "hash/fnv"
"math" "math"
"sort"
"sync/atomic" "sync/atomic"
"github.com/golang/protobuf/proto" "github.com/golang/protobuf/proto"
@ -231,11 +232,18 @@ func (h *histogram) Desc() *Desc {
} }
func (h *histogram) Observe(v float64) { func (h *histogram) Observe(v float64) {
for i, upperBound := range h.upperBounds { // TODO(beorn7): For small numbers of buckets (<30), a linear search is
if v <= upperBound { // slightly faster than the binary search. If we really care, we could
atomic.AddUint64(&h.counts[i], 1) // switch from one search strategy to the other depending on the number
break // of buckets.
} //
// Microbenchmarks (BenchmarkHistogramNoLabels):
// 11 buckets: 38.3 ns/op linear - binary 48.7 ns/op
// 100 buckets: 78.1 ns/op linear - binary 54.9 ns/op
// 300 buckets: 154 ns/op linear - binary 61.6 ns/op
i := sort.SearchFloat64s(h.upperBounds, v)
if i < len(h.counts) {
atomic.AddUint64(&h.counts[i], 1)
} }
atomic.AddUint64(&h.count, 1) atomic.AddUint64(&h.count, 1)
for { for {