mirror
/
client_golang
mirror of https://github.com/prometheus/client_golang.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #783 from roidelapluie/gc15 

Update collector comment about GC stop-the-world
This commit is contained in:
Björn Rabenstein 2020-07-24 23:48:32 +02:00 committed by GitHub
parent d3accfda21 4759649876
commit 77b35d0377
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
prometheus/go_collector.go
View File

@ -58,9 +58,10 @@ type goCollector struct {
// collector will use the memstats from a previous collection if // collector will use the memstats from a previous collection if
// runtime.ReadMemStats takes more than 1s. However, if there are no previously // runtime.ReadMemStats takes more than 1s. However, if there are no previously
// collected memstats, or their collection is more than 5m ago, the collection // collected memstats, or their collection is more than 5m ago, the collection
// will block until runtime.ReadMemStats succeeds. (The problem might be solved // will block until runtime.ReadMemStats succeeds.
// in Go1.13, see https://github.com/golang/go/issues/19812 for the related Go //
// issue.) // NOTE: The problem is solved in Go 1.15, see
// https://github.com/golang/go/issues/19812 for the related Go issue.
func NewGoCollector() Collector { func NewGoCollector() Collector {
return &goCollector{ return &goCollector{
goroutinesDesc: NewDesc( goroutinesDesc: NewDesc(