mirror
/
client_golang
mirror of https://github.com/prometheus/client_golang.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Add Content-Length header. 

Since we prepare the whole content in a buf before sending, we can as
well set the Content-Length explicitly.

Change-Id: Ifd91764c90af53be49f93f0b33032138130b6f96
This commit is contained in:
Bjoern Rabenstein 2014-07-02 18:57:34 +02:00
parent 0afe1a813e
commit 5ac9f00fa9
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
prometheus/registry.go
View File

@ -75,6 +75,7 @@ const (
capDescChan = 10 capDescChan = 10
contentTypeHeader = "Content-Type" contentTypeHeader = "Content-Type"
contentLengthHeader = "Content-Length"
) )
// Handler returns the HTTP handler for the global Prometheus registry. It is // Handler returns the HTTP handler for the global Prometheus registry. It is
@ -353,7 +354,7 @@ func (r *registry) Push(job, instance, addr, method string) error {
return err return err
} }
req, err := http.NewRequest(method, u, buf) req, err := http.NewRequest(method, u, buf)
req.Header.Set("Content-Type", DelimitedTelemetryContentType) req.Header.Set(contentTypeHeader, DelimitedTelemetryContentType)
resp, err := http.DefaultClient.Do(req) resp, err := http.DefaultClient.Do(req)
if err != nil { if err != nil {
return err return err
@ -369,7 +370,6 @@ func (r *registry) ServeHTTP(w http.ResponseWriter, req *http.Request) {
enc, contentType := chooseEncoder(req) enc, contentType := chooseEncoder(req)
buf := r.getBuf() buf := r.getBuf()
defer r.giveBuf(buf) defer r.giveBuf(buf)
header := w.Header()
if _, err := r.writePB(buf, enc); err != nil { if _, err := r.writePB(buf, enc); err != nil {
if r.panicOnCollectError { if r.panicOnCollectError {
panic(err) panic(err)
@ -377,7 +377,9 @@ func (r *registry) ServeHTTP(w http.ResponseWriter, req *http.Request) {
http.Error(w, "An error has occurred:\n\n"+err.Error(), http.StatusInternalServerError) http.Error(w, "An error has occurred:\n\n"+err.Error(), http.StatusInternalServerError)
return return
} }
header := w.Header()
header.Set(contentTypeHeader, contentType) header.Set(contentTypeHeader, contentType)
header.Set(contentLengthHeader, fmt.Sprint(buf.Len()))
w.Write(buf.Bytes()) w.Write(buf.Bytes())
} }