From 47596498769bd438949c617efac5a77909998bc3 Mon Sep 17 00:00:00 2001 From: Julien Pivotto Date: Wed, 22 Jul 2020 01:42:37 +0200 Subject: [PATCH] Update collector comment about GC stop-the-world Signed-off-by: Julien Pivotto --- prometheus/go_collector.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/prometheus/go_collector.go b/prometheus/go_collector.go index ea05cf4..6f67d10 100644 --- a/prometheus/go_collector.go +++ b/prometheus/go_collector.go @@ -58,9 +58,10 @@ type goCollector struct { // collector will use the memstats from a previous collection if // runtime.ReadMemStats takes more than 1s. However, if there are no previously // collected memstats, or their collection is more than 5m ago, the collection -// will block until runtime.ReadMemStats succeeds. (The problem might be solved -// in Go1.13, see https://github.com/golang/go/issues/19812 for the related Go -// issue.) +// will block until runtime.ReadMemStats succeeds. +// +// NOTE: The problem is solved in Go 1.15, see +// https://github.com/golang/go/issues/19812 for the related Go issue. func NewGoCollector() Collector { return &goCollector{ goroutinesDesc: NewDesc(