mirror
/
client_golang
mirror of https://github.com/prometheus/client_golang.git
1
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1387 from tsipo/main 

change api http.client to interface
This commit is contained in:
Arthur Silva Sens 2023-12-20 19:08:36 -03:00 committed by GitHub
parent 3f8bd73e9b 24d59e9b9b
commit 239b12347d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
api/client.go
View File

@ -36,14 +36,18 @@ var DefaultRoundTripper http.RoundTripper = &http.Transport{
TLSHandshakeTimeout: 10 * time.Second,
}
type HttpClient interface {
Do(req *http.Request) (*http.Response, error)
}
// Config defines configuration parameters for a new client.
type Config struct {
// The address of the Prometheus to connect to.
Address string
// Client is used by the Client to drive HTTP requests. If not provided,
// a new one based on the provided RoundTripper (or DefaultRoundTripper) will be used.
Client *http.Client
// a new http.Client based on the provided RoundTripper (or DefaultRoundTripper) will be used.
Client HttpClient
// RoundTripper is used by the Client to drive HTTP requests. If not
// provided, DefaultRoundTripper will be used.
@ -57,13 +61,13 @@ func (cfg *Config) roundTripper() http.RoundTripper {
return cfg.RoundTripper
}
func (cfg *Config) client() http.Client {
func (cfg *Config) client() HttpClient {
if cfg.Client == nil {
return http.Client{
return &http.Client{
Transport: cfg.roundTripper(),
}
}
return *cfg.Client
return cfg.Client
}
func (cfg *Config) validate() error {
@ -101,7 +105,7 @@ func NewClient(cfg Config) (Client, error) {
type httpClient struct {
endpoint *url.URL
client http.Client
client HttpClient
}
func (c *httpClient) URL(ep string, args map[string]string) *url.URL {

2
api/client_test.go
View File

@ -105,7 +105,7 @@ func TestClientURL(t *testing.T) {
hclient := &httpClient{
endpoint: ep,
client: http.Client{Transport: DefaultRoundTripper},
client: &http.Client{Transport: DefaultRoundTripper},
}
u := hclient.URL(test.endpoint, test.args)