2015-02-02 17:14:36 +03:00
|
|
|
// Copyright 2014 The Prometheus Authors
|
2014-05-07 22:08:33 +04:00
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package prometheus
|
|
|
|
|
|
|
|
import (
|
|
|
|
"encoding/json"
|
|
|
|
"expvar"
|
|
|
|
)
|
|
|
|
|
|
|
|
// ExpvarCollector collects metrics from the expvar interface. It provides a
|
|
|
|
// quick way to expose numeric values that are already exported via expvar as
|
|
|
|
// Prometheus metrics. Note that the data models of expvar and Prometheus are
|
|
|
|
// fundamentally different, and that the ExpvarCollector is inherently
|
|
|
|
// slow. Thus, the ExpvarCollector is probably great for experiments and
|
|
|
|
// prototying, but you should seriously consider a more direct implementation of
|
|
|
|
// Prometheus metrics for monitoring production systems.
|
|
|
|
//
|
|
|
|
// Use NewExpvarCollector to create new instances.
|
|
|
|
type ExpvarCollector struct {
|
|
|
|
exports map[string]*Desc
|
|
|
|
}
|
|
|
|
|
|
|
|
// NewExpvarCollector returns a newly allocated ExpvarCollector that still has
|
|
|
|
// to be registered with the Prometheus registry.
|
|
|
|
//
|
|
|
|
// The exports map has the following meaning:
|
|
|
|
//
|
|
|
|
// The keys in the map correspond to expvar keys, i.e. for every expvar key you
|
|
|
|
// want to export as Prometheus metric, you need an entry in the exports
|
|
|
|
// map. The descriptor mapped to each key describes how to export the expvar
|
|
|
|
// value. It defines the name and the help string of the Prometheus metric
|
|
|
|
// proxying the expvar value. The type will always be Untyped.
|
|
|
|
//
|
|
|
|
// For descriptors without variable labels, the expvar value must be a number or
|
|
|
|
// a bool. The number is then directly exported as the Prometheus sample
|
|
|
|
// value. (For a bool, 'false' translates to 0 and 'true' to 1). Expvar values
|
|
|
|
// that are not numbers or bools are silently ignored.
|
|
|
|
//
|
|
|
|
// If the descriptor has one variable label, the expvar value must be an expvar
|
|
|
|
// map. The keys in the expvar map become the various values of the one
|
|
|
|
// Prometheus label. The values in the expvar map must be numbers or bools again
|
|
|
|
// as above.
|
|
|
|
//
|
|
|
|
// For descriptors with more than one variable label, the expvar must be a
|
|
|
|
// nested expvar map, i.e. where the values of the topmost map are maps again
|
|
|
|
// etc. until a depth is reached that corresponds to the number of labels. The
|
|
|
|
// leaves of that structure must be numbers or bools as above to serve as the
|
|
|
|
// sample values.
|
|
|
|
//
|
|
|
|
// Anything that does not fit into the scheme above is silently ignored.
|
|
|
|
func NewExpvarCollector(exports map[string]*Desc) *ExpvarCollector {
|
|
|
|
return &ExpvarCollector{
|
|
|
|
exports: exports,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Describe implements Collector.
|
|
|
|
func (e *ExpvarCollector) Describe(ch chan<- *Desc) {
|
|
|
|
for _, desc := range e.exports {
|
|
|
|
ch <- desc
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Collect implements Collector.
|
|
|
|
func (e *ExpvarCollector) Collect(ch chan<- Metric) {
|
|
|
|
for name, desc := range e.exports {
|
|
|
|
var m Metric
|
|
|
|
expVar := expvar.Get(name)
|
|
|
|
if expVar == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
var v interface{}
|
|
|
|
labels := make([]string, len(desc.variableLabels))
|
Allow error reporting during metrics collection and simplify Register().
Both are interface changes I want to get in before public
announcement. They only break rare usage cases, and are always easy to
fix, but still we want to avoid breaking changes after a wider
announcement of the project.
The change of Register() simply removes the return of the Collector,
which nobody was using in practice. It was just bloating the call
syntax. Note that this is different from RegisterOrGet(), which is
used at various occasions where you want to register something that
might or might not be registered already, but if it is, you want the
previously registered Collector back (because that's the relevant
one).
WRT error reporting: I first tried the obvious way of letting the
Collector methods Describe() and Collect() return error. However, I
had to conclude that that bloated _many_ calls and their handling in
very obnoxious ways. On the other hand, the case where you actually
want to report errors during registration or collection is very
rare. Hence, this approach has the wrong trade-off. The approach taken
here might at first appear clunky but is in practice quite handy,
mostly because there is almost no change for the "normal" case of "no
special error handling", but also because it plays well with the way
descriptors and metrics are handled (via channels).
Explaining the approach in more detail:
- During registration / describe: Error handling was actually already
in place (for invalid descriptors, which carry an error anyway). I
only added a convenience function to create an invalid descriptor
with a given error on purpose.
- Metrics are now treated in a similar way. The Write method returns
an error now (the only change in interface). An "invalid metric" is
provided that can be sent via the channel to signal that that metric
could not be collected. It alse transports an error.
NON-GOALS OF THIS COMMIT:
This is NOT yet the major improvement of the whole registry part,
where we want a public Registry interface and plenty of modular
configurations (for error handling, various auto-metrics, http
instrumentation, testing, ...). However, we can do that whole thing
without breaking existing interfaces. For now (which is a significant
issue) any error during collection will either cause a 500 HTTP
response or a panic (depending on registry config). Later, we
definitely want to have a possibility to skip (and only report
somehow) non-collectible metrics instead of aborting the whole scrape.
2015-01-12 21:16:09 +03:00
|
|
|
if err := json.Unmarshal([]byte(expVar.String()), &v); err != nil {
|
|
|
|
ch <- NewInvalidMetric(desc, err)
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
var processValue func(v interface{}, i int)
|
|
|
|
processValue = func(v interface{}, i int) {
|
|
|
|
if i >= len(labels) {
|
|
|
|
copiedLabels := append(make([]string, 0, len(labels)), labels...)
|
|
|
|
switch v := v.(type) {
|
|
|
|
case float64:
|
|
|
|
m = MustNewConstMetric(desc, UntypedValue, v, copiedLabels...)
|
|
|
|
case bool:
|
|
|
|
if v {
|
|
|
|
m = MustNewConstMetric(desc, UntypedValue, 1, copiedLabels...)
|
|
|
|
} else {
|
|
|
|
m = MustNewConstMetric(desc, UntypedValue, 0, copiedLabels...)
|
2014-05-07 22:08:33 +04:00
|
|
|
}
|
Allow error reporting during metrics collection and simplify Register().
Both are interface changes I want to get in before public
announcement. They only break rare usage cases, and are always easy to
fix, but still we want to avoid breaking changes after a wider
announcement of the project.
The change of Register() simply removes the return of the Collector,
which nobody was using in practice. It was just bloating the call
syntax. Note that this is different from RegisterOrGet(), which is
used at various occasions where you want to register something that
might or might not be registered already, but if it is, you want the
previously registered Collector back (because that's the relevant
one).
WRT error reporting: I first tried the obvious way of letting the
Collector methods Describe() and Collect() return error. However, I
had to conclude that that bloated _many_ calls and their handling in
very obnoxious ways. On the other hand, the case where you actually
want to report errors during registration or collection is very
rare. Hence, this approach has the wrong trade-off. The approach taken
here might at first appear clunky but is in practice quite handy,
mostly because there is almost no change for the "normal" case of "no
special error handling", but also because it plays well with the way
descriptors and metrics are handled (via channels).
Explaining the approach in more detail:
- During registration / describe: Error handling was actually already
in place (for invalid descriptors, which carry an error anyway). I
only added a convenience function to create an invalid descriptor
with a given error on purpose.
- Metrics are now treated in a similar way. The Write method returns
an error now (the only change in interface). An "invalid metric" is
provided that can be sent via the channel to signal that that metric
could not be collected. It alse transports an error.
NON-GOALS OF THIS COMMIT:
This is NOT yet the major improvement of the whole registry part,
where we want a public Registry interface and plenty of modular
configurations (for error handling, various auto-metrics, http
instrumentation, testing, ...). However, we can do that whole thing
without breaking existing interfaces. For now (which is a significant
issue) any error during collection will either cause a 500 HTTP
response or a panic (depending on registry config). Later, we
definitely want to have a possibility to skip (and only report
somehow) non-collectible metrics instead of aborting the whole scrape.
2015-01-12 21:16:09 +03:00
|
|
|
default:
|
2014-05-07 22:08:33 +04:00
|
|
|
return
|
|
|
|
}
|
Allow error reporting during metrics collection and simplify Register().
Both are interface changes I want to get in before public
announcement. They only break rare usage cases, and are always easy to
fix, but still we want to avoid breaking changes after a wider
announcement of the project.
The change of Register() simply removes the return of the Collector,
which nobody was using in practice. It was just bloating the call
syntax. Note that this is different from RegisterOrGet(), which is
used at various occasions where you want to register something that
might or might not be registered already, but if it is, you want the
previously registered Collector back (because that's the relevant
one).
WRT error reporting: I first tried the obvious way of letting the
Collector methods Describe() and Collect() return error. However, I
had to conclude that that bloated _many_ calls and their handling in
very obnoxious ways. On the other hand, the case where you actually
want to report errors during registration or collection is very
rare. Hence, this approach has the wrong trade-off. The approach taken
here might at first appear clunky but is in practice quite handy,
mostly because there is almost no change for the "normal" case of "no
special error handling", but also because it plays well with the way
descriptors and metrics are handled (via channels).
Explaining the approach in more detail:
- During registration / describe: Error handling was actually already
in place (for invalid descriptors, which carry an error anyway). I
only added a convenience function to create an invalid descriptor
with a given error on purpose.
- Metrics are now treated in a similar way. The Write method returns
an error now (the only change in interface). An "invalid metric" is
provided that can be sent via the channel to signal that that metric
could not be collected. It alse transports an error.
NON-GOALS OF THIS COMMIT:
This is NOT yet the major improvement of the whole registry part,
where we want a public Registry interface and plenty of modular
configurations (for error handling, various auto-metrics, http
instrumentation, testing, ...). However, we can do that whole thing
without breaking existing interfaces. For now (which is a significant
issue) any error during collection will either cause a 500 HTTP
response or a panic (depending on registry config). Later, we
definitely want to have a possibility to skip (and only report
somehow) non-collectible metrics instead of aborting the whole scrape.
2015-01-12 21:16:09 +03:00
|
|
|
ch <- m
|
|
|
|
return
|
|
|
|
}
|
|
|
|
vm, ok := v.(map[string]interface{})
|
|
|
|
if !ok {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
for lv, val := range vm {
|
|
|
|
labels[i] = lv
|
|
|
|
processValue(val, i+1)
|
2014-05-07 22:08:33 +04:00
|
|
|
}
|
|
|
|
}
|
Allow error reporting during metrics collection and simplify Register().
Both are interface changes I want to get in before public
announcement. They only break rare usage cases, and are always easy to
fix, but still we want to avoid breaking changes after a wider
announcement of the project.
The change of Register() simply removes the return of the Collector,
which nobody was using in practice. It was just bloating the call
syntax. Note that this is different from RegisterOrGet(), which is
used at various occasions where you want to register something that
might or might not be registered already, but if it is, you want the
previously registered Collector back (because that's the relevant
one).
WRT error reporting: I first tried the obvious way of letting the
Collector methods Describe() and Collect() return error. However, I
had to conclude that that bloated _many_ calls and their handling in
very obnoxious ways. On the other hand, the case where you actually
want to report errors during registration or collection is very
rare. Hence, this approach has the wrong trade-off. The approach taken
here might at first appear clunky but is in practice quite handy,
mostly because there is almost no change for the "normal" case of "no
special error handling", but also because it plays well with the way
descriptors and metrics are handled (via channels).
Explaining the approach in more detail:
- During registration / describe: Error handling was actually already
in place (for invalid descriptors, which carry an error anyway). I
only added a convenience function to create an invalid descriptor
with a given error on purpose.
- Metrics are now treated in a similar way. The Write method returns
an error now (the only change in interface). An "invalid metric" is
provided that can be sent via the channel to signal that that metric
could not be collected. It alse transports an error.
NON-GOALS OF THIS COMMIT:
This is NOT yet the major improvement of the whole registry part,
where we want a public Registry interface and plenty of modular
configurations (for error handling, various auto-metrics, http
instrumentation, testing, ...). However, we can do that whole thing
without breaking existing interfaces. For now (which is a significant
issue) any error during collection will either cause a 500 HTTP
response or a panic (depending on registry config). Later, we
definitely want to have a possibility to skip (and only report
somehow) non-collectible metrics instead of aborting the whole scrape.
2015-01-12 21:16:09 +03:00
|
|
|
processValue(v, 0)
|
2014-05-07 22:08:33 +04:00
|
|
|
}
|
|
|
|
}
|