Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
// Copyright 2021 The Prometheus Authors
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
//go:build go1.17
|
|
|
|
// +build go1.17
|
|
|
|
|
|
|
|
package prometheus
|
|
|
|
|
|
|
|
import (
|
2024-08-09 22:27:25 +03:00
|
|
|
"fmt"
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
"math"
|
|
|
|
"runtime"
|
|
|
|
"runtime/metrics"
|
2022-01-28 07:46:45 +03:00
|
|
|
"strings"
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
"sync"
|
|
|
|
|
2022-05-13 11:04:45 +03:00
|
|
|
"github.com/prometheus/client_golang/prometheus/internal"
|
2022-12-22 18:14:00 +03:00
|
|
|
|
|
|
|
dto "github.com/prometheus/client_model/go"
|
|
|
|
"google.golang.org/protobuf/proto"
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
)
|
|
|
|
|
2022-04-13 11:55:22 +03:00
|
|
|
const (
|
2022-08-05 20:37:46 +03:00
|
|
|
// constants for strings referenced more than once.
|
2022-04-13 11:55:22 +03:00
|
|
|
goGCHeapTinyAllocsObjects = "/gc/heap/tiny/allocs:objects"
|
|
|
|
goGCHeapAllocsObjects = "/gc/heap/allocs:objects"
|
|
|
|
goGCHeapFreesObjects = "/gc/heap/frees:objects"
|
2022-08-05 20:37:46 +03:00
|
|
|
goGCHeapFreesBytes = "/gc/heap/frees:bytes"
|
2022-04-13 11:55:22 +03:00
|
|
|
goGCHeapAllocsBytes = "/gc/heap/allocs:bytes"
|
|
|
|
goGCHeapObjects = "/gc/heap/objects:objects"
|
|
|
|
goGCHeapGoalBytes = "/gc/heap/goal:bytes"
|
|
|
|
goMemoryClassesTotalBytes = "/memory/classes/total:bytes"
|
|
|
|
goMemoryClassesHeapObjectsBytes = "/memory/classes/heap/objects:bytes"
|
|
|
|
goMemoryClassesHeapUnusedBytes = "/memory/classes/heap/unused:bytes"
|
|
|
|
goMemoryClassesHeapReleasedBytes = "/memory/classes/heap/released:bytes"
|
|
|
|
goMemoryClassesHeapFreeBytes = "/memory/classes/heap/free:bytes"
|
|
|
|
goMemoryClassesHeapStacksBytes = "/memory/classes/heap/stacks:bytes"
|
|
|
|
goMemoryClassesOSStacksBytes = "/memory/classes/os-stacks:bytes"
|
|
|
|
goMemoryClassesMetadataMSpanInuseBytes = "/memory/classes/metadata/mspan/inuse:bytes"
|
|
|
|
goMemoryClassesMetadataMSPanFreeBytes = "/memory/classes/metadata/mspan/free:bytes"
|
|
|
|
goMemoryClassesMetadataMCacheInuseBytes = "/memory/classes/metadata/mcache/inuse:bytes"
|
|
|
|
goMemoryClassesMetadataMCacheFreeBytes = "/memory/classes/metadata/mcache/free:bytes"
|
|
|
|
goMemoryClassesProfilingBucketsBytes = "/memory/classes/profiling/buckets:bytes"
|
|
|
|
goMemoryClassesMetadataOtherBytes = "/memory/classes/metadata/other:bytes"
|
|
|
|
goMemoryClassesOtherBytes = "/memory/classes/other:bytes"
|
|
|
|
)
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
// rmNamesForMemStatsMetrics represents runtime/metrics names required to populate goRuntimeMemStats from like logic.
|
|
|
|
var rmNamesForMemStatsMetrics = []string{
|
2022-06-17 10:04:06 +03:00
|
|
|
goGCHeapTinyAllocsObjects,
|
2022-04-13 11:55:22 +03:00
|
|
|
goGCHeapAllocsObjects,
|
|
|
|
goGCHeapFreesObjects,
|
|
|
|
goGCHeapAllocsBytes,
|
|
|
|
goGCHeapObjects,
|
|
|
|
goGCHeapGoalBytes,
|
|
|
|
goMemoryClassesTotalBytes,
|
|
|
|
goMemoryClassesHeapObjectsBytes,
|
|
|
|
goMemoryClassesHeapUnusedBytes,
|
|
|
|
goMemoryClassesHeapReleasedBytes,
|
|
|
|
goMemoryClassesHeapFreeBytes,
|
|
|
|
goMemoryClassesHeapStacksBytes,
|
|
|
|
goMemoryClassesOSStacksBytes,
|
|
|
|
goMemoryClassesMetadataMSpanInuseBytes,
|
|
|
|
goMemoryClassesMetadataMSPanFreeBytes,
|
|
|
|
goMemoryClassesMetadataMCacheInuseBytes,
|
|
|
|
goMemoryClassesMetadataMCacheFreeBytes,
|
|
|
|
goMemoryClassesProfilingBucketsBytes,
|
|
|
|
goMemoryClassesMetadataOtherBytes,
|
|
|
|
goMemoryClassesOtherBytes,
|
|
|
|
}
|
|
|
|
|
|
|
|
func bestEffortLookupRM(lookup []string) []metrics.Description {
|
|
|
|
ret := make([]metrics.Description, 0, len(lookup))
|
|
|
|
for _, rm := range metrics.All() {
|
|
|
|
for _, m := range lookup {
|
|
|
|
if m == rm.Name {
|
|
|
|
ret = append(ret, rm)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ret
|
|
|
|
}
|
|
|
|
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
type goCollector struct {
|
|
|
|
base baseGoCollector
|
|
|
|
|
2022-01-25 10:43:45 +03:00
|
|
|
// mu protects updates to all fields ensuring a consistent
|
|
|
|
// snapshot is always produced by Collect.
|
|
|
|
mu sync.Mutex
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
// Contains all samples that has to retrieved from runtime/metrics (not all of them will be exposed).
|
|
|
|
sampleBuf []metrics.Sample
|
|
|
|
// sampleMap allows lookup for MemStats metrics and runtime/metrics histograms for exact sums.
|
|
|
|
sampleMap map[string]*metrics.Sample
|
|
|
|
|
|
|
|
// rmExposedMetrics represents all runtime/metrics package metrics
|
|
|
|
// that were configured to be exposed.
|
|
|
|
rmExposedMetrics []collectorMetric
|
|
|
|
rmExactSumMapForHist map[string]string
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
|
|
|
|
// With Go 1.17, the runtime/metrics package was introduced.
|
|
|
|
// From that point on, metric names produced by the runtime/metrics
|
|
|
|
// package could be generated from runtime/metrics names. However,
|
|
|
|
// these differ from the old names for the same values.
|
|
|
|
//
|
2022-08-05 20:37:46 +03:00
|
|
|
// This field exists to export the same values under the old names
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
// as well.
|
2022-08-05 20:37:46 +03:00
|
|
|
msMetrics memStatsMetrics
|
|
|
|
msMetricsEnabled bool
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
type rmMetricDesc struct {
|
|
|
|
metrics.Description
|
2022-04-13 11:55:22 +03:00
|
|
|
}
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
func matchRuntimeMetricsRules(rules []internal.GoCollectorRule) []rmMetricDesc {
|
|
|
|
var descs []rmMetricDesc
|
|
|
|
for _, d := range metrics.All() {
|
|
|
|
var (
|
|
|
|
deny = true
|
|
|
|
desc rmMetricDesc
|
|
|
|
)
|
|
|
|
|
|
|
|
for _, r := range rules {
|
|
|
|
if !r.Matcher.MatchString(d.Name) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
deny = r.Deny
|
|
|
|
}
|
|
|
|
if deny {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
desc.Description = d
|
|
|
|
descs = append(descs, desc)
|
|
|
|
}
|
|
|
|
return descs
|
2022-04-13 11:55:22 +03:00
|
|
|
}
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
func defaultGoCollectorOptions() internal.GoCollectorOptions {
|
|
|
|
return internal.GoCollectorOptions{
|
|
|
|
RuntimeMetricSumForHist: map[string]string{
|
|
|
|
"/gc/heap/allocs-by-size:bytes": goGCHeapAllocsBytes,
|
|
|
|
"/gc/heap/frees-by-size:bytes": goGCHeapFreesBytes,
|
|
|
|
},
|
|
|
|
RuntimeMetricRules: []internal.GoCollectorRule{
|
2024-08-09 22:27:25 +03:00
|
|
|
// Recommended metrics we want by default from runtime/metrics.
|
|
|
|
{Matcher: internal.GoCollectorDefaultRuntimeMetrics},
|
2022-08-05 20:37:46 +03:00
|
|
|
},
|
|
|
|
}
|
|
|
|
}
|
2022-04-13 11:55:22 +03:00
|
|
|
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
// NewGoCollector is the obsolete version of collectors.NewGoCollector.
|
|
|
|
// See there for documentation.
|
|
|
|
//
|
|
|
|
// Deprecated: Use collectors.NewGoCollector instead.
|
2022-08-05 20:37:46 +03:00
|
|
|
func NewGoCollector(opts ...func(o *internal.GoCollectorOptions)) Collector {
|
|
|
|
opt := defaultGoCollectorOptions()
|
2022-04-13 11:55:22 +03:00
|
|
|
for _, o := range opts {
|
|
|
|
o(&opt)
|
|
|
|
}
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
exposedDescriptions := matchRuntimeMetricsRules(opt.RuntimeMetricRules)
|
2022-01-28 07:46:45 +03:00
|
|
|
|
|
|
|
// Collect all histogram samples so that we can get their buckets.
|
|
|
|
// The API guarantees that the buckets are always fixed for the lifetime
|
|
|
|
// of the process.
|
|
|
|
var histograms []metrics.Sample
|
2022-08-05 20:37:46 +03:00
|
|
|
for _, d := range exposedDescriptions {
|
2022-01-28 07:46:45 +03:00
|
|
|
if d.Kind == metrics.KindFloat64Histogram {
|
|
|
|
histograms = append(histograms, metrics.Sample{Name: d.Name})
|
|
|
|
}
|
|
|
|
}
|
2022-04-13 11:55:22 +03:00
|
|
|
|
|
|
|
if len(histograms) > 0 {
|
|
|
|
metrics.Read(histograms)
|
|
|
|
}
|
|
|
|
|
2022-01-28 07:46:45 +03:00
|
|
|
bucketsMap := make(map[string][]float64)
|
|
|
|
for i := range histograms {
|
|
|
|
bucketsMap[histograms[i].Name] = histograms[i].Value.Float64Histogram().Buckets
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
// Generate a collector for each exposed runtime/metrics metric.
|
|
|
|
metricSet := make([]collectorMetric, 0, len(exposedDescriptions))
|
|
|
|
// SampleBuf is used for reading from runtime/metrics.
|
|
|
|
// We are assuming the largest case to have stable pointers for sampleMap purposes.
|
|
|
|
sampleBuf := make([]metrics.Sample, 0, len(exposedDescriptions)+len(opt.RuntimeMetricSumForHist)+len(rmNamesForMemStatsMetrics))
|
|
|
|
sampleMap := make(map[string]*metrics.Sample, len(exposedDescriptions))
|
|
|
|
for _, d := range exposedDescriptions {
|
|
|
|
namespace, subsystem, name, ok := internal.RuntimeMetricsToProm(&d.Description)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
if !ok {
|
|
|
|
// Just ignore this metric; we can't do anything with it here.
|
|
|
|
// If a user decides to use the latest version of Go, we don't want
|
2022-04-13 11:55:22 +03:00
|
|
|
// to fail here. This condition is tested in TestExpectedRuntimeMetrics.
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
continue
|
|
|
|
}
|
2024-08-14 15:25:55 +03:00
|
|
|
help := attachOriginalName(d.Description.Description, d.Name)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
|
|
|
|
sampleBuf = append(sampleBuf, metrics.Sample{Name: d.Name})
|
|
|
|
sampleMap[d.Name] = &sampleBuf[len(sampleBuf)-1]
|
|
|
|
|
2022-01-21 10:34:45 +03:00
|
|
|
var m collectorMetric
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
if d.Kind == metrics.KindFloat64Histogram {
|
2022-08-05 20:37:46 +03:00
|
|
|
_, hasSum := opt.RuntimeMetricSumForHist[d.Name]
|
2022-01-28 07:46:45 +03:00
|
|
|
unit := d.Name[strings.IndexRune(d.Name, ':')+1:]
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
m = newBatchHistogram(
|
|
|
|
NewDesc(
|
|
|
|
BuildFQName(namespace, subsystem, name),
|
2024-08-14 15:25:55 +03:00
|
|
|
help,
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
nil,
|
|
|
|
nil,
|
|
|
|
),
|
2022-01-28 07:46:45 +03:00
|
|
|
internal.RuntimeMetricsBucketsForUnit(bucketsMap[d.Name], unit),
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
hasSum,
|
|
|
|
)
|
|
|
|
} else if d.Cumulative {
|
|
|
|
m = NewCounter(CounterOpts{
|
|
|
|
Namespace: namespace,
|
|
|
|
Subsystem: subsystem,
|
|
|
|
Name: name,
|
2024-08-14 15:25:55 +03:00
|
|
|
Help: help,
|
2022-08-05 20:37:46 +03:00
|
|
|
},
|
|
|
|
)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
} else {
|
|
|
|
m = NewGauge(GaugeOpts{
|
|
|
|
Namespace: namespace,
|
|
|
|
Subsystem: subsystem,
|
|
|
|
Name: name,
|
2024-08-14 15:25:55 +03:00
|
|
|
Help: help,
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
})
|
|
|
|
}
|
|
|
|
metricSet = append(metricSet, m)
|
|
|
|
}
|
2022-04-13 11:55:22 +03:00
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
// Add exact sum metrics to sampleBuf if not added before.
|
|
|
|
for _, h := range histograms {
|
|
|
|
sumMetric, ok := opt.RuntimeMetricSumForHist[h.Name]
|
|
|
|
if !ok {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if _, ok := sampleMap[sumMetric]; ok {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
sampleBuf = append(sampleBuf, metrics.Sample{Name: sumMetric})
|
|
|
|
sampleMap[sumMetric] = &sampleBuf[len(sampleBuf)-1]
|
|
|
|
}
|
|
|
|
|
|
|
|
var (
|
|
|
|
msMetrics memStatsMetrics
|
|
|
|
msDescriptions []metrics.Description
|
|
|
|
)
|
|
|
|
|
|
|
|
if !opt.DisableMemStatsLikeMetrics {
|
2022-04-13 11:55:22 +03:00
|
|
|
msMetrics = goRuntimeMemStats()
|
2022-08-05 20:37:46 +03:00
|
|
|
msDescriptions = bestEffortLookupRM(rmNamesForMemStatsMetrics)
|
|
|
|
|
|
|
|
// Check if metric was not exposed before and if not, add to sampleBuf.
|
|
|
|
for _, mdDesc := range msDescriptions {
|
|
|
|
if _, ok := sampleMap[mdDesc.Name]; ok {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
sampleBuf = append(sampleBuf, metrics.Sample{Name: mdDesc.Name})
|
|
|
|
sampleMap[mdDesc.Name] = &sampleBuf[len(sampleBuf)-1]
|
|
|
|
}
|
2022-04-13 11:55:22 +03:00
|
|
|
}
|
2022-08-05 20:37:46 +03:00
|
|
|
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
return &goCollector{
|
2022-08-05 20:37:46 +03:00
|
|
|
base: newBaseGoCollector(),
|
|
|
|
sampleBuf: sampleBuf,
|
|
|
|
sampleMap: sampleMap,
|
|
|
|
rmExposedMetrics: metricSet,
|
|
|
|
rmExactSumMapForHist: opt.RuntimeMetricSumForHist,
|
|
|
|
msMetrics: msMetrics,
|
|
|
|
msMetricsEnabled: !opt.DisableMemStatsLikeMetrics,
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-08-14 15:25:55 +03:00
|
|
|
func attachOriginalName(desc, origName string) string {
|
|
|
|
return fmt.Sprintf("%s Sourced from %s", desc, origName)
|
|
|
|
}
|
|
|
|
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
// Describe returns all descriptions of the collector.
|
|
|
|
func (c *goCollector) Describe(ch chan<- *Desc) {
|
|
|
|
c.base.Describe(ch)
|
|
|
|
for _, i := range c.msMetrics {
|
|
|
|
ch <- i.desc
|
|
|
|
}
|
2022-08-05 20:37:46 +03:00
|
|
|
for _, m := range c.rmExposedMetrics {
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
ch <- m.Desc()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Collect returns the current state of all metrics of the collector.
|
|
|
|
func (c *goCollector) Collect(ch chan<- Metric) {
|
|
|
|
// Collect base non-memory metrics.
|
|
|
|
c.base.Collect(ch)
|
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
if len(c.sampleBuf) == 0 {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2022-01-21 10:34:45 +03:00
|
|
|
// Collect must be thread-safe, so prevent concurrent use of
|
2022-08-05 20:37:46 +03:00
|
|
|
// sampleBuf elements. Just read into sampleBuf but write all the data
|
2022-01-21 10:34:45 +03:00
|
|
|
// we get into our Metrics or MemStats.
|
|
|
|
//
|
2022-01-25 10:43:45 +03:00
|
|
|
// This lock also ensures that the Metrics we send out are all from
|
|
|
|
// the same updates, ensuring their mutual consistency insofar as
|
|
|
|
// is guaranteed by the runtime/metrics package.
|
|
|
|
//
|
|
|
|
// N.B. This locking is heavy-handed, but Collect is expected to be called
|
|
|
|
// relatively infrequently. Also the core operation here, metrics.Read,
|
|
|
|
// is fast (O(tens of microseconds)) so contention should certainly be
|
|
|
|
// low, though channel operations and any allocations may add to that.
|
|
|
|
c.mu.Lock()
|
|
|
|
defer c.mu.Unlock()
|
2022-01-21 10:34:45 +03:00
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
// Populate runtime/metrics sample buffer.
|
|
|
|
metrics.Read(c.sampleBuf)
|
|
|
|
|
|
|
|
// Collect all our runtime/metrics user chose to expose from sampleBuf (if any).
|
|
|
|
for i, metric := range c.rmExposedMetrics {
|
|
|
|
// We created samples for exposed metrics first in order, so indexes match.
|
|
|
|
sample := c.sampleBuf[i]
|
|
|
|
|
|
|
|
// N.B. switch on concrete type because it's significantly more efficient
|
|
|
|
// than checking for the Counter and Gauge interface implementations. In
|
|
|
|
// this case, we control all the types here.
|
|
|
|
switch m := metric.(type) {
|
|
|
|
case *counter:
|
|
|
|
// Guard against decreases. This should never happen, but a failure
|
|
|
|
// to do so will result in a panic, which is a harsh consequence for
|
|
|
|
// a metrics collection bug.
|
|
|
|
v0, v1 := m.get(), unwrapScalarRMValue(sample.Value)
|
|
|
|
if v1 > v0 {
|
|
|
|
m.Add(unwrapScalarRMValue(sample.Value) - m.get())
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
2022-08-05 20:37:46 +03:00
|
|
|
m.Collect(ch)
|
|
|
|
case *gauge:
|
|
|
|
m.Set(unwrapScalarRMValue(sample.Value))
|
|
|
|
m.Collect(ch)
|
|
|
|
case *batchHistogram:
|
|
|
|
m.update(sample.Value.Float64Histogram(), c.exactSumFor(sample.Name))
|
|
|
|
m.Collect(ch)
|
|
|
|
default:
|
|
|
|
panic("unexpected metric type")
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
}
|
2022-04-13 11:55:22 +03:00
|
|
|
|
2022-08-05 20:37:46 +03:00
|
|
|
if c.msMetricsEnabled {
|
|
|
|
// ms is a dummy MemStats that we populate ourselves so that we can
|
|
|
|
// populate the old metrics from it if goMemStatsCollection is enabled.
|
2022-04-13 11:55:22 +03:00
|
|
|
var ms runtime.MemStats
|
2022-08-05 20:37:46 +03:00
|
|
|
memStatsFromRM(&ms, c.sampleMap)
|
2022-04-13 11:55:22 +03:00
|
|
|
for _, i := range c.msMetrics {
|
|
|
|
ch <- MustNewConstMetric(i.desc, i.valType, i.eval(&ms))
|
|
|
|
}
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// unwrapScalarRMValue unwraps a runtime/metrics value that is assumed
|
|
|
|
// to be scalar and returns the equivalent float64 value. Panics if the
|
|
|
|
// value is not scalar.
|
|
|
|
func unwrapScalarRMValue(v metrics.Value) float64 {
|
|
|
|
switch v.Kind() {
|
|
|
|
case metrics.KindUint64:
|
|
|
|
return float64(v.Uint64())
|
|
|
|
case metrics.KindFloat64:
|
|
|
|
return v.Float64()
|
|
|
|
case metrics.KindBad:
|
|
|
|
// Unsupported metric.
|
|
|
|
//
|
|
|
|
// This should never happen because we always populate our metric
|
|
|
|
// set from the runtime/metrics package.
|
2024-08-09 22:27:25 +03:00
|
|
|
panic("unexpected bad kind metric")
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
default:
|
|
|
|
// Unsupported metric kind.
|
|
|
|
//
|
|
|
|
// This should never happen because we check for this during initialization
|
|
|
|
// and flag and filter metrics whose kinds we don't understand.
|
2024-08-09 22:27:25 +03:00
|
|
|
panic(fmt.Sprintf("unexpected unsupported metric: %v", v.Kind()))
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// exactSumFor takes a runtime/metrics metric name (that is assumed to
|
|
|
|
// be of kind KindFloat64Histogram) and returns its exact sum and whether
|
|
|
|
// its exact sum exists.
|
|
|
|
//
|
|
|
|
// The runtime/metrics API for histograms doesn't currently expose exact
|
|
|
|
// sums, but some of the other metrics are in fact exact sums of histograms.
|
|
|
|
func (c *goCollector) exactSumFor(rmName string) float64 {
|
2022-08-05 20:37:46 +03:00
|
|
|
sumName, ok := c.rmExactSumMapForHist[rmName]
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
if !ok {
|
|
|
|
return 0
|
|
|
|
}
|
2022-08-05 20:37:46 +03:00
|
|
|
s, ok := c.sampleMap[sumName]
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
if !ok {
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
return unwrapScalarRMValue(s.Value)
|
|
|
|
}
|
|
|
|
|
|
|
|
func memStatsFromRM(ms *runtime.MemStats, rm map[string]*metrics.Sample) {
|
|
|
|
lookupOrZero := func(name string) uint64 {
|
|
|
|
if s, ok := rm[name]; ok {
|
|
|
|
return s.Value.Uint64()
|
|
|
|
}
|
|
|
|
return 0
|
|
|
|
}
|
|
|
|
|
|
|
|
// Currently, MemStats adds tiny alloc count to both Mallocs AND Frees.
|
|
|
|
// The reason for this is because MemStats couldn't be extended at the time
|
|
|
|
// but there was a desire to have Mallocs at least be a little more representative,
|
|
|
|
// while having Mallocs - Frees still represent a live object count.
|
|
|
|
// Unfortunately, MemStats doesn't actually export a large allocation count,
|
|
|
|
// so it's impossible to pull this number out directly.
|
2022-04-13 11:55:22 +03:00
|
|
|
tinyAllocs := lookupOrZero(goGCHeapTinyAllocsObjects)
|
|
|
|
ms.Mallocs = lookupOrZero(goGCHeapAllocsObjects) + tinyAllocs
|
|
|
|
ms.Frees = lookupOrZero(goGCHeapFreesObjects) + tinyAllocs
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
|
2022-04-13 11:55:22 +03:00
|
|
|
ms.TotalAlloc = lookupOrZero(goGCHeapAllocsBytes)
|
|
|
|
ms.Sys = lookupOrZero(goMemoryClassesTotalBytes)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
ms.Lookups = 0 // Already always zero.
|
2022-04-13 11:55:22 +03:00
|
|
|
ms.HeapAlloc = lookupOrZero(goMemoryClassesHeapObjectsBytes)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
ms.Alloc = ms.HeapAlloc
|
2022-04-13 11:55:22 +03:00
|
|
|
ms.HeapInuse = ms.HeapAlloc + lookupOrZero(goMemoryClassesHeapUnusedBytes)
|
|
|
|
ms.HeapReleased = lookupOrZero(goMemoryClassesHeapReleasedBytes)
|
|
|
|
ms.HeapIdle = ms.HeapReleased + lookupOrZero(goMemoryClassesHeapFreeBytes)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
ms.HeapSys = ms.HeapInuse + ms.HeapIdle
|
2022-04-13 11:55:22 +03:00
|
|
|
ms.HeapObjects = lookupOrZero(goGCHeapObjects)
|
|
|
|
ms.StackInuse = lookupOrZero(goMemoryClassesHeapStacksBytes)
|
|
|
|
ms.StackSys = ms.StackInuse + lookupOrZero(goMemoryClassesOSStacksBytes)
|
|
|
|
ms.MSpanInuse = lookupOrZero(goMemoryClassesMetadataMSpanInuseBytes)
|
|
|
|
ms.MSpanSys = ms.MSpanInuse + lookupOrZero(goMemoryClassesMetadataMSPanFreeBytes)
|
|
|
|
ms.MCacheInuse = lookupOrZero(goMemoryClassesMetadataMCacheInuseBytes)
|
|
|
|
ms.MCacheSys = ms.MCacheInuse + lookupOrZero(goMemoryClassesMetadataMCacheFreeBytes)
|
|
|
|
ms.BuckHashSys = lookupOrZero(goMemoryClassesProfilingBucketsBytes)
|
|
|
|
ms.GCSys = lookupOrZero(goMemoryClassesMetadataOtherBytes)
|
|
|
|
ms.OtherSys = lookupOrZero(goMemoryClassesOtherBytes)
|
|
|
|
ms.NextGC = lookupOrZero(goGCHeapGoalBytes)
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
|
|
|
|
// N.B. GCCPUFraction is intentionally omitted. This metric is not useful,
|
|
|
|
// and often misleading due to the fact that it's an average over the lifetime
|
|
|
|
// of the process.
|
|
|
|
// See https://github.com/prometheus/client_golang/issues/842#issuecomment-861812034
|
|
|
|
// for more details.
|
|
|
|
ms.GCCPUFraction = 0
|
|
|
|
}
|
|
|
|
|
|
|
|
// batchHistogram is a mutable histogram that is updated
|
|
|
|
// in batches.
|
|
|
|
type batchHistogram struct {
|
|
|
|
selfCollector
|
|
|
|
|
|
|
|
// Static fields updated only once.
|
|
|
|
desc *Desc
|
|
|
|
hasSum bool
|
|
|
|
|
|
|
|
// Because this histogram operates in batches, it just uses a
|
|
|
|
// single mutex for everything. updates are always serialized
|
|
|
|
// but Write calls may operate concurrently with updates.
|
|
|
|
// Contention between these two sources should be rare.
|
|
|
|
mu sync.Mutex
|
2022-01-28 07:46:45 +03:00
|
|
|
buckets []float64 // Inclusive lower bounds, like runtime/metrics.
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
counts []uint64
|
|
|
|
sum float64 // Used if hasSum is true.
|
|
|
|
}
|
|
|
|
|
2022-01-28 07:46:45 +03:00
|
|
|
// newBatchHistogram creates a new batch histogram value with the given
|
|
|
|
// Desc, buckets, and whether or not it has an exact sum available.
|
|
|
|
//
|
|
|
|
// buckets must always be from the runtime/metrics package, following
|
|
|
|
// the same conventions.
|
|
|
|
func newBatchHistogram(desc *Desc, buckets []float64, hasSum bool) *batchHistogram {
|
2022-05-13 11:04:45 +03:00
|
|
|
// We need to remove -Inf values. runtime/metrics keeps them around.
|
|
|
|
// But -Inf bucket should not be allowed for prometheus histograms.
|
|
|
|
if buckets[0] == math.Inf(-1) {
|
|
|
|
buckets = buckets[1:]
|
|
|
|
}
|
2022-01-28 07:46:45 +03:00
|
|
|
h := &batchHistogram{
|
|
|
|
desc: desc,
|
|
|
|
buckets: buckets,
|
|
|
|
// Because buckets follows runtime/metrics conventions, there's
|
|
|
|
// 1 more value in the buckets list than there are buckets represented,
|
|
|
|
// because in runtime/metrics, the bucket values represent *boundaries*,
|
|
|
|
// and non-Inf boundaries are inclusive lower bounds for that bucket.
|
|
|
|
counts: make([]uint64, len(buckets)-1),
|
|
|
|
hasSum: hasSum,
|
|
|
|
}
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
h.init(h)
|
|
|
|
return h
|
|
|
|
}
|
|
|
|
|
|
|
|
// update updates the batchHistogram from a runtime/metrics histogram.
|
|
|
|
//
|
|
|
|
// sum must be provided if the batchHistogram was created to have an exact sum.
|
2022-01-28 07:46:45 +03:00
|
|
|
// h.buckets must be a strict subset of his.Buckets.
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
func (h *batchHistogram) update(his *metrics.Float64Histogram, sum float64) {
|
|
|
|
counts, buckets := his.Counts, his.Buckets
|
|
|
|
|
|
|
|
h.mu.Lock()
|
|
|
|
defer h.mu.Unlock()
|
|
|
|
|
2022-01-28 07:46:45 +03:00
|
|
|
// Clear buckets.
|
|
|
|
for i := range h.counts {
|
|
|
|
h.counts[i] = 0
|
|
|
|
}
|
|
|
|
// Copy and reduce buckets.
|
|
|
|
var j int
|
|
|
|
for i, count := range counts {
|
|
|
|
h.counts[j] += count
|
|
|
|
if buckets[i+1] == h.buckets[j+1] {
|
|
|
|
j++
|
|
|
|
}
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
if h.hasSum {
|
|
|
|
h.sum = sum
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (h *batchHistogram) Desc() *Desc {
|
|
|
|
return h.desc
|
|
|
|
}
|
|
|
|
|
|
|
|
func (h *batchHistogram) Write(out *dto.Metric) error {
|
|
|
|
h.mu.Lock()
|
|
|
|
defer h.mu.Unlock()
|
|
|
|
|
|
|
|
sum := float64(0)
|
|
|
|
if h.hasSum {
|
|
|
|
sum = h.sum
|
|
|
|
}
|
|
|
|
dtoBuckets := make([]*dto.Bucket, 0, len(h.counts))
|
|
|
|
totalCount := uint64(0)
|
|
|
|
for i, count := range h.counts {
|
|
|
|
totalCount += count
|
|
|
|
if !h.hasSum {
|
2022-05-13 11:04:45 +03:00
|
|
|
if count != 0 {
|
|
|
|
// N.B. This computed sum is an underestimate.
|
|
|
|
sum += h.buckets[i] * float64(count)
|
|
|
|
}
|
Use the runtime/metrics package for the Go collector for 1.17+ (#955)
This change introduces use of the runtime/metrics package in place of
runtime.MemStats for Go 1.17 or later. The runtime/metrics package was
introduced in Go 1.16, but not all the old metrics were accounted for
until 1.17.
The runtime/metrics package offers several advantages over using
runtime.MemStats:
* The list of metrics and their descriptions are machine-readable,
allowing new metrics to get added without any additional work.
* Detailed histogram-based metrics are now available, offering much
deeper insights into the Go runtime.
* The runtime/metrics API is significantly more efficient than
runtime.MemStats, even with the additional metrics added, because
it does not require any stop-the-world events.
That being said, integrating the package comes with some caveats, some
of which were discussed in #842. Namely:
* The old MemStats-based metrics need to continue working, so they're
exported under their old names backed by equivalent runtime/metrics
metrics.
* Earlier versions of Go need to continue working, so the old code
remains, but behind a build tag.
Finally, a few notes about the implementation:
* This change includes a whole bunch of refactoring to avoid significant
code duplication.
* This change adds a new histogram metric type specifically optimized
for runtime/metrics histograms. This type's methods also include
additional logic to deal with differences in bounds conventions.
* This change makes a whole bunch of decisions about how runtime/metrics
names are translated.
* This change adds a `go generate` script to generate a list of expected
runtime/metrics names for a given Go version for auditing. Users of
new versions of Go will transparently be allowed to use new metrics,
however.
Signed-off-by: Michael Anthony Knyszek <mknyszek@google.com>
2022-01-16 19:41:56 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
// Skip the +Inf bucket, but only for the bucket list.
|
|
|
|
// It must still count for sum and totalCount.
|
|
|
|
if math.IsInf(h.buckets[i+1], 1) {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
// Float64Histogram's upper bound is exclusive, so make it inclusive
|
|
|
|
// by obtaining the next float64 value down, in order.
|
|
|
|
upperBound := math.Nextafter(h.buckets[i+1], h.buckets[i])
|
|
|
|
dtoBuckets = append(dtoBuckets, &dto.Bucket{
|
|
|
|
CumulativeCount: proto.Uint64(totalCount),
|
|
|
|
UpperBound: proto.Float64(upperBound),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
out.Histogram = &dto.Histogram{
|
|
|
|
Bucket: dtoBuckets,
|
|
|
|
SampleCount: proto.Uint64(totalCount),
|
|
|
|
SampleSum: proto.Float64(sum),
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|