Commit Graph

3218 Commits

Author SHA1 Message Date
Dan Kortschak fed9d366c6 rtmp: remove C_Aval from C_AMFObjectProperty 2018-09-06 16:49:25 +09:30
Dan Kortschak c4800034a6 rtmp: remove C_AVal from P_vu 2018-09-06 16:10:15 +09:30
Dan Kortschak ed40f36ffe rtmp: remove C_AVal from C_AMF3ReadString
Note that this function is not used.
2018-09-06 15:57:09 +09:30
Dan Kortschak f005c31b44 rtmp: encode/decode typed boolean 2018-09-06 15:36:27 +09:30
Dan Kortschak 470e61a465 rtmp: remove C_AVal from encoder/decoder functions 2018-09-06 15:32:29 +09:30
Dan Kortschak 019a1f1c90 rtmp: make string decoding a returning function 2018-09-06 12:46:07 +09:30
Dan Kortschak a626a740ea rtmp: remove missed comments 2018-09-06 12:29:03 +09:30
Dan Kortschak aac0801cdb rtmp: use bytes.Equal for signature matching 2018-09-06 12:26:35 +09:30
Dan Kortschak 6c6ed78e8f rtmp: convert boolish ints to bool 2018-09-06 12:18:45 +09:30
Dan Kortschak f3a0968fb4 rtmp: port C_CloseInternal 2018-09-06 11:46:48 +09:30
Dan Kortschak 8674b23b28 rtmp: port C_SendFCUnpublish 2018-09-06 11:26:52 +09:30
Dan Kortschak b7c148fd93 rtmp: simplify body pointer setup 2018-09-06 11:11:29 +09:30
Dan Kortschak c31021149d rtmp: remove redundant comments 2018-09-06 11:04:08 +09:30
Saxon Milton 257544ef3f Merged in rtmp-unsafe-cleanup (pull request #52)
Rtmp unsafe cleanup

Approved-by: kortschak <dan@kortschak.io>
2018-09-05 03:40:53 +00:00
Dan Kortschak 7bfea781b4 rtmp: remove redundant size adjustment 2018-09-04 14:07:49 +09:30
saxon 078ba12093 rtmp: tried to replicate C behaviour by returning would be no of bytes written 2018-09-02 14:20:25 +09:30
saxon 8cf8f07b9c rtmp: corrected C_RTMP_Write c file line number 2018-09-02 13:40:18 +09:30
saxon 3d3ec6b893 rtmp: check that len(buf) is not less than 4 before buf = buf[4:] 2018-09-02 13:31:52 +09:30
saxon 6da0967b80 rtmp: removed check to see if byte slice length is less that 0 - which doesn't happen 2018-09-02 12:27:25 +09:30
saxon 9b152f0495 rtmp: removed math.Abs in C_RTMP_Write for checking noOfBytesRead 2018-09-02 11:35:32 +09:30
saxon 24968c83b3 rtmp: removed use of s2 and replaced with len(buf) 2018-09-02 11:32:11 +09:30
saxon 390c882792 rtmp: removed comments containing previous code in C_RTMP_Write 2018-09-02 10:21:10 +09:30
saxon 269c8176a1 rtmp: changed data slice to buf to simplify 2018-09-02 10:19:29 +09:30
saxon e861420e69 Merge branch 'master' into rtmp-unsafe-cleanup 2018-09-02 00:04:32 +09:30
saxon b3c25d3bc7 rtmp: initial commit 2018-09-02 00:03:30 +09:30
kortschak f2def3fd34 Merged in rtmp/unsafe-cleanup (pull request #51)
rtmp: unsafe cleanup

Approved-by: Saxon Milton <saxon.milton@gmail.com>
2018-09-01 14:22:17 +00:00
Dan Kortschak 4fa4dce908 rtmp: remove redundant reconversions 2018-09-01 23:35:28 +09:30
Dan Kortschak 05bed207b3 rtmp: remove unnecessary int conversions 2018-09-01 23:31:20 +09:30
Dan Kortschak 74e468dfb3 rtmp: remove unnecessary type conversions with unconvert 2018-09-01 23:31:08 +09:30
saxon 287c3d32ac rtmp: tried removing some unsafe pointers in C_RTMP_Write - ended up breaking it. Youtube tells me it's starting but it now goes live 2018-09-01 23:23:07 +09:30
Dan Kortschak 40785e7454 rtmp: make tests pass 2018-09-01 23:20:32 +09:30
Dan Kortschak c494da9a1d rtmp: remove indxBytePtr
Manual clean up.
2018-08-31 12:01:34 +09:30
Dan Kortschak e235da36a1 rtmp: simplify slice conversion
Second pass:

gofmt -w -r 'ptrToSlice(p,i)->(*[_Gi]byte)(p)[:i]' {rtmp,parseurl,amf}.go
2018-08-31 11:43:49 +09:30
Dan Kortschak 52c6b1f60a rtmp: simplify unsafe slice conversion
Mechanical:

gofmt -w -r 'ptrToSlice(unsafe.Pointer(p),i)->(*[_Gi]byte)(unsafe.Pointer(p))[:i]' {rtmp,parseurl,amf}.go
2018-08-31 11:42:22 +09:30
Dan Kortschak 0053034e94 rtmp: simplify indexing
This is a mechanical change in line with the previous:

gofmt -w -r '*indxBytePtr(p,i)->(*[_Gi]byte)(p)[i]' {rtmp,parseurl,amf}.go
2018-08-31 11:29:41 +09:30
Dan Kortschak 18e1e7fc45 rtmp: simplify indexing
This is a mechanical change with the addition of a constant:

gofmt -w -r '*indxBytePtr(unsafe.Pointer(p), i)->(*[_Gi]byte)(unsafe.Pointer(p))[i]' {rtmp,parseurl,amf}.go
2018-08-31 11:24:42 +09:30
Dan Kortschak 6187df1c20 rtmp: remove deadcode and make tests pass 2018-08-31 11:13:59 +09:30
Saxon Milton ddefd198d0 Merged in rtmp-structure-improvements (pull request #48)
rtmp: structure improvements

Approved-by: kortschak <dan@kortschak.io>
2018-08-30 11:06:44 +00:00
Dan Kortschak 4aad7bac04 rtmp: remove rtmp.c 2018-08-30 20:34:09 +09:30
Dan Kortschak 7da8c11c58 rtmp: port add_addr_info and remove unused includes 2018-08-30 20:31:19 +09:30
kortschak 933367c06c Merged in lexer (pull request #50)
lex: add missing lex package

Approved-by: kortschak <dan@kortschak.io>
2018-08-28 11:00:26 +00:00
Dan Kortschak 562ae8d3f3 lex: add missing lex package 2018-08-28 20:28:57 +09:30
saxon e0c3cd3b32 rtmp: added more funcs to NOT_PORTED and removed commented out sections from AMFProp_Decode in amf.go 2018-08-28 20:10:13 +09:30
saxon 01f3caa8ec rtmp: created NOT_PORTED.txt to hold names of funcs not ported and also deleted sections of code not run in our case 2018-08-28 19:18:13 +09:30
saxon 766d30e2f6 rtmp: setting r.m_nClientBW2 to 255 rather than 0 (which was incorrect in C_HandlClientBW 2018-08-28 18:50:51 +09:30
saxon 8318f34be4 rtmp: removed case braces in C_HandlInvoke and replaced code not run with panics in case we do get those cases 2018-08-28 18:40:10 +09:30
saxon bd630fd893 rtmp: added all consts/flags from C library 2018-08-26 14:35:04 +09:30
saxon b846dbf2d7 rtmp: continued to port C_SendFCUnpublish - paused - need to work out best way to get rid of unsafe pointers 2018-08-26 00:27:38 +09:30
saxon 9384927113 rtmp: start porting C_SendFCUnpublish 2018-08-26 00:18:28 +09:30
saxon 9b67dc1ef0 rtmp: added comments above C_RTMP_Close and C_CloseInternal to indicate location in C library, and reordered to better resemble C library 2018-08-26 00:13:08 +09:30