Commit Graph

98 Commits

Author SHA1 Message Date
Saxon 07a6cfcf68 protocol/rtp/client.go: commented PacketReader 2019-05-13 14:03:11 +09:30
Saxon 4f55f2bed1 protocol/rtp/client.go: initialising PacketReader now to fix build runtime panic 2019-05-11 22:04:45 +09:30
Saxon 6acc2d7376 protocol/rtp/client.go: wrote PacketReader type
Client now possesses a PacketReader which has it's Read func wrapped by the Client's Read func
2019-05-11 22:01:07 +09:30
Saxon Milton a5e40472d4 Merged in rtsp-protocol (pull request #185)
protocol: added basic RTCP protocol client implementation.

Approved-by: Alan Noble <anoble@gmail.com>
Approved-by: kortschak <dan@kortschak.io>
2019-05-09 03:06:37 +00:00
Saxon 524dbea0e1 protocol/rtcp/client.go: added comment for Log func signature type 2019-05-09 12:28:31 +09:30
Saxon 5bd0e31db3 protocol/rtcp/client.go: fixed filename in file header 2019-05-09 12:24:48 +09:30
Saxon 51160c8849 protocol/rtcp/client.go: export log type 2019-05-09 11:41:51 +09:30
Saxon 841dccaec8 protocol/rtcp/rtcp.go: added package comment 2019-05-09 11:35:07 +09:30
Saxon Milton 080800d43a Merged in rtp-client (pull request #186)
protocol/rtp: RTP client

Approved-by: kortschak <dan@kortschak.io>
Approved-by: Alan Noble <anoble@gmail.com>
2019-05-09 01:22:54 +00:00
Saxon 3692ba772d protocol/rtp/client.go: removed dummyLogger as not required anymore. 2019-05-08 16:57:58 +09:30
Saxon 534a0bcecb protocol/rtp/client.go: updated file description in file header. 2019-05-08 16:57:07 +09:30
Saxon c48e681c41 protocol/rtp/client.go: removed buffering in client.
Removed buffering in rtp client. This simplified things alot e.g. the recv routine has been removed, and therefore anything that was there to help with handling of the routine is also gone
like the Start() and Stop() methods as well as signalling channels and waitgroups. The client is now just effectively a wrapper for a udp conn.
2019-05-08 16:54:02 +09:30
Saxon 7e96f5999c protocol/rtp/client.go: updated comment for NewClient to remove mention of removed op argument 2019-05-08 15:47:11 +09:30
Saxon aa7553947a protocol/rtp/rtp.go: renamed Pkt type to Packet. 2019-05-08 15:45:08 +09:30
Saxon a06083ecb7 protocol/rtcp/client.go: no newline at the end of error string in parse() 2019-05-08 13:54:56 +09:30
Saxon f5d38b1bfc protocol/rtcp/client.go: using fmt.Errorf rather than errors.New(fmt.Sprintf(...)) in parse() 2019-05-08 13:53:36 +09:30
Saxon ea309b295e protocol/rtcp/client.go: only using one quit chan for both send and recv routines. 2019-05-08 13:51:54 +09:30
Saxon 76612ea8df protocol/rtcp/client.go: not embedding log 2019-05-08 13:49:09 +09:30
Saxon 040cd18db3 protocol/rtcp/client.go: moved err chan to bottom of fields list. 2019-05-08 13:48:12 +09:30
Saxon c9aa43394b protocol/rtp/client.go: got rid of useless continue in recv dst write if error encountered 2019-05-03 20:04:06 +09:30
Saxon 2f039e0c4b protoocl/rtp: removed comment for 'misc constants' 2019-05-03 20:02:29 +09:30
Saxon 9b3523607b protocol/rtcp: added todo comment to jitter() 2019-05-03 20:00:18 +09:30
Saxon 7fe5e74123 protocol/rtcp/client.go: added comment for Err() regarding usage. 2019-05-03 19:58:50 +09:30
Saxon 80a7d41d8a protocol/rtp: removed op from Client i.e. what is read from Client are RTP packets. 2019-05-01 14:15:39 +09:30
Saxon d358f70585 protocol/rtp: made client_test.go more robust 2019-04-30 09:39:41 +09:30
Saxon 6694cab956 protocol/rtp: commented Client.Err() 2019-04-30 02:38:38 +09:30
Saxon 49a401681d protocol/rtp: Client.ErrChan => Client.err and wrote accessor function Client.Err() to access this chan as only receive 2019-04-30 02:37:18 +09:30
Saxon Milton b4ff40e269 Merged in remove-early-ringbuffer (pull request #184)
revid: removed main ringBuffer

Approved-by: Alan Noble <anoble@gmail.com>
Approved-by: kortschak <dan@kortschak.io>
2019-04-27 12:24:08 +00:00
Alan Noble 149a2fa6b9 Fix package-level doc comment. 2019-04-26 00:36:23 +00:00
Saxon e00c959a84 protocol/rtcp: renamed NTPTimestamp to Timestamp
Renamed NTPTimestamp and referenced specifications rather than quoting. Renamed Timestamp func to ParseTimestamp.
2019-04-23 16:40:26 +09:30
Saxon 63da7dbb59 protocol/rtcp: removed unecessary logging in test files 2019-04-23 14:45:16 +09:30
Saxon 017abea667 protocol/rtcp: fixed indentation in file headers 2019-04-23 14:38:26 +09:30
Saxon 4c2962ba75 protocol/rtcp: renamed SourceDescription to Description 2019-04-23 14:33:27 +09:30
Saxon 889072bde0 protocol/rtcp: improve ReportBlock field names 2019-04-23 14:30:05 +09:30
Saxon 4068aea207 protocol/rtp: better comment for NTPTimestamp and renamed fields 2019-04-23 14:25:22 +09:30
Saxon b43f6f8072 protocol/rtcp: renamed highestSequence() to sequence. 2019-04-23 14:16:40 +09:30
Saxon 6b994d0dba protocol/rtcp: made Client error channel unexported
Renamed Client ErrChan field to err, i.e. made unexported. Wrote Err() accessor that allows user to only read from error channel.
2019-04-23 13:26:56 +09:30
Saxon a43ef56618 protocol/rtcp: addressing PR feedback 2019-04-22 00:34:03 +09:30
Saxon cbad00b6e6 av: fixed conflict 2019-04-21 23:58:59 +09:30
Saxon a0c324a813 protocol/rtp: simplified test
Simplified clien_test.go file by testing two different RTP packet operations using loop. We now first test no operation,
and then test a rtp.Payload operation, which gets the payload of the packets and stores them in the client ringbuffer for the
user of the client to read.
2019-04-21 23:07:30 +09:30
Saxon be76998c7d protocol/rtp: wrote TestReceiveNoOp
Wrote test TestReceiveNoOP to check that client works correctly when we give no operation to perform on RTP packets before
storing in the client ringBuffer, which calling io.Reader implementation Read will get packets form.
2019-04-21 22:40:08 +09:30
Saxon f454a34856 protocol/rtp: added client_test.go for client testing 2019-04-20 21:10:03 +09:30
Saxon 00db293b44 protocol/rtp: consts for chan and ringbuffer sizes 2019-04-20 21:05:34 +09:30
Saxon 190d546c58 protocol/rtp: commented file 2019-04-19 18:40:15 +09:30
Saxon b302eafa68 protocol/rtp: setting Client's op field in constructor 2019-04-19 18:22:43 +09:30
Saxon ccc08bfad1 protoocl/rtp: added client.go file
Added client.go which contains a struct to describe an RTP client. It provides a method, Start, which will
invoke a recv routine to start receiving packets and process them using an op function passed on the Client's
creation. Client implements io.Reader, so that the client may be read from.
2019-04-19 18:17:06 +09:30
Saxon a8e56311c2 protocol/rtcp: addressing PR feedback 2019-04-19 14:15:43 +09:30
Saxon d34eabcd34 protocol/rtcp/client.go: not using defer for simple setters/getters 2019-04-17 07:41:31 +09:30
Saxon 881ddc3d38 protocol/rtcp: using defer where I can 2019-04-16 22:01:38 +09:30
Saxon f66a94543a protocol/rtcp: fixed some further feedback 2019-04-16 17:17:48 +09:30