Commit Graph

2348 Commits

Author SHA1 Message Date
Saxon e00c959a84 protocol/rtcp: renamed NTPTimestamp to Timestamp
Renamed NTPTimestamp and referenced specifications rather than quoting. Renamed Timestamp func to ParseTimestamp.
2019-04-23 16:40:26 +09:30
Saxon 63da7dbb59 protocol/rtcp: removed unecessary logging in test files 2019-04-23 14:45:16 +09:30
Saxon 017abea667 protocol/rtcp: fixed indentation in file headers 2019-04-23 14:38:26 +09:30
Saxon 4c2962ba75 protocol/rtcp: renamed SourceDescription to Description 2019-04-23 14:33:27 +09:30
Saxon 889072bde0 protocol/rtcp: improve ReportBlock field names 2019-04-23 14:30:05 +09:30
Saxon 4068aea207 protocol/rtp: better comment for NTPTimestamp and renamed fields 2019-04-23 14:25:22 +09:30
Saxon b43f6f8072 protocol/rtcp: renamed highestSequence() to sequence. 2019-04-23 14:16:40 +09:30
Saxon 6b994d0dba protocol/rtcp: made Client error channel unexported
Renamed Client ErrChan field to err, i.e. made unexported. Wrote Err() accessor that allows user to only read from error channel.
2019-04-23 13:26:56 +09:30
Saxon e5f95d1ea0 revid: addressing PR feedback 2019-04-23 13:18:41 +09:30
Saxon 9ba72fac62 av: addressing PR feedback 2019-04-22 15:14:08 +09:30
Saxon a43ef56618 protocol/rtcp: addressing PR feedback 2019-04-22 00:34:03 +09:30
Saxon cbad00b6e6 av: fixed conflict 2019-04-21 23:58:59 +09:30
Saxon a0c324a813 protocol/rtp: simplified test
Simplified clien_test.go file by testing two different RTP packet operations using loop. We now first test no operation,
and then test a rtp.Payload operation, which gets the payload of the packets and stores them in the client ringbuffer for the
user of the client to read.
2019-04-21 23:07:30 +09:30
Saxon be76998c7d protocol/rtp: wrote TestReceiveNoOp
Wrote test TestReceiveNoOP to check that client works correctly when we give no operation to perform on RTP packets before
storing in the client ringBuffer, which calling io.Reader implementation Read will get packets form.
2019-04-21 22:40:08 +09:30
Saxon f454a34856 protocol/rtp: added client_test.go for client testing 2019-04-20 21:10:03 +09:30
Saxon 00db293b44 protocol/rtp: consts for chan and ringbuffer sizes 2019-04-20 21:05:34 +09:30
scruzin 81e3038b9b go.mod: use ausocean/utils v1.2.6 2019-04-20 18:19:25 +09:30
Saxon 190d546c58 protocol/rtp: commented file 2019-04-19 18:40:15 +09:30
Saxon b302eafa68 protocol/rtp: setting Client's op field in constructor 2019-04-19 18:22:43 +09:30
Saxon ccc08bfad1 protoocl/rtp: added client.go file
Added client.go which contains a struct to describe an RTP client. It provides a method, Start, which will
invoke a recv routine to start receiving packets and process them using an op function passed on the Client's
creation. Client implements io.Reader, so that the client may be read from.
2019-04-19 18:17:06 +09:30
Saxon a8e56311c2 protocol/rtcp: addressing PR feedback 2019-04-19 14:15:43 +09:30
Saxon d76b60a515 revid: addressing PR feedback 2019-04-18 18:31:49 +09:30
Saxon 74c995d452 revid: addressing PR feedback 2019-04-18 16:55:48 +09:30
Saxon 1c5d3997bb revid: fixed indentation on Dan's name under authors 2019-04-18 16:21:18 +09:30
Saxon d34eabcd34 protocol/rtcp/client.go: not using defer for simple setters/getters 2019-04-17 07:41:31 +09:30
Saxon 881ddc3d38 protocol/rtcp: using defer where I can 2019-04-16 22:01:38 +09:30
Saxon f66a94543a protocol/rtcp: fixed some further feedback 2019-04-16 17:17:48 +09:30
Saxon 51478ee064 protocol/rtcp: addressing of PR feedback 2019-04-16 17:16:13 +09:30
Saxon f54dd13959 protocol/rtcp: added file headers 2019-04-16 16:45:44 +09:30
Saxon 5cf39595eb protocol/rtcp: fix case of protocols in comments 2019-04-16 16:31:04 +09:30
Saxon 9e55feafe7 protocol: removed rtsp stuff
For this branch we will only include efforts regarding rtcp.
2019-04-16 12:38:14 +09:30
Saxon 1a19412223 protocol/rtcp: finished client_test.go improved usability or client
Finished writing the client_test.go file and through the process fixed some bugs in the client. Also increased usability by providing a Stop() method
so that the send and recv routines, and also the connection can be terminated. Also created a sender report struct in rtcp.go - this helped with
testing.
2019-04-16 12:33:58 +09:30
Saxon Milton 6ee286e988 Merged in rtp-parsing (pull request #179)
protocol/rtp: can parse payload from RTP packet

Approved-by: Alan Noble <anoble@gmail.com>
Approved-by: kortschak <dan@kortschak.io>
2019-04-16 00:31:21 +00:00
Saxon aa947d112c protocol/rtcp: wrote test for Client.formPayload 2019-04-15 17:35:36 +09:30
Saxon dca007a5ba rtcp/protocol: tried to make Bytes funcs and client formation of payload more efficient 2019-04-15 16:56:52 +09:30
Saxon 2669862ced protocol/rtcp: wrote struct for RTCP sender report 2019-04-15 15:53:06 +09:30
Saxon af664b0661 protocol/rtsp: more commenting and started writing client_test.go to check the behaviour of the rtcp client 2019-04-15 14:01:38 +09:30
Saxon e3c711d1f6 cmd/revid-cli: run failed log message to warning level 2019-04-15 13:13:01 +09:30
Saxon cea3a5958a revid: changed no location in reply log message to level debug 2019-04-15 13:09:56 +09:30
Saxon 56a9b7d6ef av: fixed broken tests 2019-04-15 11:43:46 +09:30
Saxon 3534d9031a av: updated go mod 2019-04-15 11:26:40 +09:30
Saxon 88431b1357 revid: made rtmpSender smarter with write error handling 2019-04-15 11:20:36 +09:30
Saxon d18373908b revid: added ringBuffer to rtmpSender 2019-04-15 10:48:12 +09:30
Saxon d75ea20137 revid: applying some feedback from last PR 2019-04-15 10:25:35 +09:30
Saxon f59879b51d revid: removed ringBuffer after lexer
Now that we want buffered senders (as required), the ringBuffer that was after the
lexer has been removed. Instead, we now have an ioext.multiWriterCloser to which the
lexer writes to. This then writes to the encoders, and then encoders write to each of
their own multiWriteClosers, which write to the appropriate senders. We now call
close on the first multiWriteCloser to close down the entired pipeline, as this close
call propogates through each level.

We have removed the outputClips routine as it's not required anymore to get data
from the revid ringBuffer, and have removed other things that were used by this, like
the IsRunning function.

We have also updated tests to work with these changes - they are passing.
2019-04-15 08:42:56 +09:30
Saxon 4a613e600c protocol/rtp: fixed gnu license url in file headers for parse_test.go and parse.go 2019-04-14 17:08:42 +09:30
Saxon Milton 899a2fe89e Merged in buffered-mts-sender (pull request #180)
revid: Buffered MtsSender

Approved-by: kortschak <dan@kortschak.io>
2019-04-14 01:44:53 +00:00
Saxon b347f2e9d1 revid: set revid.isRunning to false before waiting, because this is what triggers output routine to be killed. 2019-04-14 11:13:17 +09:30
Saxon 5cd12bff8a revid: dummyLogger in senders_test.go now uses pointer receiver for log 2019-04-13 20:41:47 +09:30
Saxon 9b48d22392 av: fixed conflicts with master 2019-04-13 20:15:08 +09:30