Merged in v-h-flip-variable-name (pull request #301)

Flip Horizontal & Flip Vertical variables renamed to match convention

Approved-by: Saxon Milton <saxon.milton@gmail.com>

cmd/revid-cli/main.go

@@ -237,8 +237,8 @@ func handleFlags() config.Config {
 
 	cfg.CameraIP = *cameraIPPtr
 	cfg.Rotation = *rotationPtr
-	cfg.FlipHorizontal = *horizontalFlipPtr
-	cfg.FlipVertical = *verticalFlipPtr
+	cfg.HorizontalFlip = *horizontalFlipPtr
+	cfg.VerticalFlip = *verticalFlipPtr
 	cfg.RTMPURL = *rtmpUrlPtr
 	cfg.Bitrate = *bitratePtr
 	cfg.OutputPath = *outputPathPtr

device/raspivid/raspivid.go

@@ -222,14 +222,14 @@ func (r *Raspivid) Start() error {
 		"--awb", fmt.Sprint(r.cfg.AutoWhiteBalance),
 	}
 
-	if r.cfg.FlipHorizontal {
+	if r.cfg.HorizontalFlip {
 		args = append(args, "--hflip")
 	}
 
-	if r.cfg.FlipVertical {
+	if r.cfg.VerticalFlip {
 		args = append(args, "--vflip")
 	}
-	if r.cfg.FlipHorizontal {
+	if r.cfg.HorizontalFlip {
 		args = append(args, "--hflip")
 	}
 

revid/config/config.go

@@ -244,8 +244,8 @@ type Config struct {
 	Height         uint   // Height defines the input video height Raspivid input.
 	Width          uint   // Width defines the input video width Raspivid input.
 	Bitrate        uint   // Bitrate specifies the bitrate for constant bitrate in kbps.
-	FlipHorizontal bool   // FlipHorizontal flips video horizontally for Raspivid input.
-	FlipVertical   bool   // FlipVertial flips video vertically for Raspivid input.
+	HorizontalFlip bool   // HorizontalFlip flips video horizontally for Raspivid input.
+	VerticalFlip   bool   // VerticalFlip flips video vertically for Raspivid input.
 
 	// RTMP ring buffer parameters.
 	RTMPRBSize         int // The number of elements in the RTMP sender ringbuffer.

revid/revid.go

@@ -596,18 +596,18 @@ func (r *Revid) Update(vars map[string]string) error {
 		case "HorizontalFlip":
 			switch strings.ToLower(value) {
 			case "true":
-				r.cfg.FlipHorizontal = true
+				r.cfg.HorizontalFlip = true
 			case "false":
-				r.cfg.FlipHorizontal = false
+				r.cfg.HorizontalFlip = false
 			default:
 				r.cfg.Logger.Log(logger.Warning, pkg+"invalid HorizontalFlip param", "value", value)
 			}
 		case "VerticalFlip":
 			switch strings.ToLower(value) {
 			case "true":
-				r.cfg.FlipVertical = true
+				r.cfg.VerticalFlip = true
 			case "false":
-				r.cfg.FlipVertical = false
+				r.cfg.VerticalFlip = false
 			default:
 				r.cfg.Logger.Log(logger.Warning, pkg+"invalid VerticalFlip param", "value", value)
 			}