From 7192c392b20bb5cf004ec097860994912e0c07fb Mon Sep 17 00:00:00 2001 From: Scott Date: Wed, 5 Feb 2020 09:49:21 +1030 Subject: [PATCH] revid: remove cmd field from revid struct --- revid/revid.go | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/revid/revid.go b/revid/revid.go index faac33a9..82fc7dea 100644 --- a/revid/revid.go +++ b/revid/revid.go @@ -33,7 +33,6 @@ import ( "errors" "fmt" "io" - "os/exec" "strconv" "strings" "sync" @@ -91,12 +90,6 @@ type Revid struct { // in Revid.Stop(). closeInput func() error - // cmd is the exec'd process that may be used to produce - // the input stream. - // FIXME(kortschak): This should not exist. Replace this - // with a context.Context cancellation. - cmd *exec.Cmd - // lexTo, encoder and packer handle transcoding the input stream. lexTo func(dest io.Writer, src io.Reader, delay time.Duration) error @@ -481,10 +474,6 @@ func (r *Revid) Stop() { r.cfg.Logger.Log(logger.Info, pkg+"closed pipeline") - if r.cmd != nil && r.cmd.Process != nil { - r.cfg.Logger.Log(logger.Info, pkg+"killing input proccess") - r.cmd.Process.Kill() - } r.cfg.Logger.Log(logger.Info, pkg+"waiting for routines to close") r.wg.Wait()