remove useless return value from pool function

This commit is contained in:
Andy Pan 2018-12-01 19:22:05 +08:00
parent d052cf95e1
commit d8c168b198
4 changed files with 7 additions and 12 deletions

View File

@ -36,13 +36,12 @@ const (
benchAntsSize = 200000 benchAntsSize = 200000
) )
func demoFunc() error { func demoFunc() {
n := 10 n := 10
time.Sleep(time.Duration(n) * time.Millisecond) time.Sleep(time.Duration(n) * time.Millisecond)
return nil
} }
func demoPoolFunc(args interface{}) error { func demoPoolFunc(args interface{}) {
//m := args.(int) //m := args.(int)
//var n int //var n int
//for i := 0; i < m; i++ { //for i := 0; i < m; i++ {
@ -51,7 +50,6 @@ func demoPoolFunc(args interface{}) error {
//return nil //return nil
n := args.(int) n := args.(int)
time.Sleep(time.Duration(n) * time.Millisecond) time.Sleep(time.Duration(n) * time.Millisecond)
return nil
} }
func BenchmarkGoroutineWithFunc(b *testing.B) { func BenchmarkGoroutineWithFunc(b *testing.B) {
@ -88,10 +86,9 @@ func BenchmarkSemaphoreWithFunc(b *testing.B) {
func BenchmarkAntsPoolWithFunc(b *testing.B) { func BenchmarkAntsPoolWithFunc(b *testing.B) {
var wg sync.WaitGroup var wg sync.WaitGroup
p, _ := ants.NewPoolWithFunc(benchAntsSize, func(i interface{}) error { p, _ := ants.NewPoolWithFunc(benchAntsSize, func(i interface{}) {
demoPoolFunc(i) demoPoolFunc(i)
wg.Done() wg.Done()
return nil
}) })
defer p.Release() defer p.Release()

View File

@ -54,10 +54,9 @@ var curMem uint64
func TestAntsPoolWithFunc(t *testing.T) { func TestAntsPoolWithFunc(t *testing.T) {
var wg sync.WaitGroup var wg sync.WaitGroup
p, _ := ants.NewPoolWithFunc(AntsSize, func(i interface{}) error { p, _ := ants.NewPoolWithFunc(AntsSize, func(i interface{}) {
demoPoolFunc(i) demoPoolFunc(i)
wg.Done() wg.Done()
return nil
}) })
defer p.Release() defer p.Release()
@ -94,10 +93,9 @@ func TestAntsPool(t *testing.T) {
var wg sync.WaitGroup var wg sync.WaitGroup
for i := 0; i < n; i++ { for i := 0; i < n; i++ {
wg.Add(1) wg.Add(1)
ants.Submit(func() error { ants.Submit(func(){
demoFunc() demoFunc()
wg.Done() wg.Done()
return nil
}) })
} }
wg.Wait() wg.Wait()

View File

@ -30,7 +30,7 @@ import (
type sig struct{} type sig struct{}
type f func() error type f func()
// Pool accept the tasks from client,it limits the total // Pool accept the tasks from client,it limits the total
// of goroutines to a given number by recycling goroutines. // of goroutines to a given number by recycling goroutines.

View File

@ -28,7 +28,7 @@ import (
"time" "time"
) )
type pf func(interface{}) error type pf func(interface{})
// PoolWithFunc accept the tasks from client,it limits the total // PoolWithFunc accept the tasks from client,it limits the total
// of goroutines to a given number by recycling goroutines. // of goroutines to a given number by recycling goroutines.