From d8c168b198f9bcc73521fc18a1a3f9f85149b705 Mon Sep 17 00:00:00 2001
From: Andy Pan <panjf2000@gmail.com>
Date: Sat, 1 Dec 2018 19:22:05 +0800
Subject: [PATCH] remove useless return value from pool function

---
 ants_benchmark_test.go | 9 +++------
 ants_test.go           | 6 ++----
 pool.go                | 2 +-
 pool_func.go           | 2 +-
 4 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/ants_benchmark_test.go b/ants_benchmark_test.go
index daef33c..2b1f327 100644
--- a/ants_benchmark_test.go
+++ b/ants_benchmark_test.go
@@ -36,13 +36,12 @@ const (
 	benchAntsSize = 200000
 )
 
-func demoFunc() error {
+func demoFunc() {
 	n := 10
 	time.Sleep(time.Duration(n) * time.Millisecond)
-	return nil
 }
 
-func demoPoolFunc(args interface{}) error {
+func demoPoolFunc(args interface{}) {
 	//m := args.(int)
 	//var n int
 	//for i := 0; i < m; i++ {
@@ -51,7 +50,6 @@ func demoPoolFunc(args interface{}) error {
 	//return nil
 	n := args.(int)
 	time.Sleep(time.Duration(n) * time.Millisecond)
-	return nil
 }
 
 func BenchmarkGoroutineWithFunc(b *testing.B) {
@@ -88,10 +86,9 @@ func BenchmarkSemaphoreWithFunc(b *testing.B) {
 
 func BenchmarkAntsPoolWithFunc(b *testing.B) {
 	var wg sync.WaitGroup
-	p, _ := ants.NewPoolWithFunc(benchAntsSize, func(i interface{}) error {
+	p, _ := ants.NewPoolWithFunc(benchAntsSize, func(i interface{}) {
 		demoPoolFunc(i)
 		wg.Done()
-		return nil
 	})
 	defer p.Release()
 
diff --git a/ants_test.go b/ants_test.go
index 2ced83d..957bbce 100644
--- a/ants_test.go
+++ b/ants_test.go
@@ -54,10 +54,9 @@ var curMem uint64
 
 func TestAntsPoolWithFunc(t *testing.T) {
 	var wg sync.WaitGroup
-	p, _ := ants.NewPoolWithFunc(AntsSize, func(i interface{}) error {
+	p, _ := ants.NewPoolWithFunc(AntsSize, func(i interface{}) {
 		demoPoolFunc(i)
 		wg.Done()
-		return nil
 	})
 	defer p.Release()
 
@@ -94,10 +93,9 @@ func TestAntsPool(t *testing.T) {
 	var wg sync.WaitGroup
 	for i := 0; i < n; i++ {
 		wg.Add(1)
-		ants.Submit(func() error {
+		ants.Submit(func(){
 			demoFunc()
 			wg.Done()
-			return nil
 		})
 	}
 	wg.Wait()
diff --git a/pool.go b/pool.go
index 52a16f1..c7e9aa7 100644
--- a/pool.go
+++ b/pool.go
@@ -30,7 +30,7 @@ import (
 
 type sig struct{}
 
-type f func() error
+type f func()
 
 // Pool accept the tasks from client,it limits the total
 // of goroutines to a given number by recycling goroutines.
diff --git a/pool_func.go b/pool_func.go
index aff43cb..4ccbb0f 100644
--- a/pool_func.go
+++ b/pool_func.go
@@ -28,7 +28,7 @@ import (
 	"time"
 )
 
-type pf func(interface{}) error
+type pf func(interface{})
 
 // PoolWithFunc accept the tasks from client,it limits the total
 // of goroutines to a given number by recycling goroutines.