Corrects a bug where passing an empty tar reader to tarfs would cause
adding the pseudoroot to panic with assignment to entry in nil map.
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
* Initial commit for tarfs
* tarfs: reword "open" status field
* tarfs: use TestMain for FS setup
We want to have the FS variable available through all the tests, so we
we use a common "setup" function to initialise it.
* tarfs: test: early exit for nonexisting files
* tarfs: create test for filesystem Open
* tarfs: implement File.Stat
* tarfs: implement Fs.Open
* tarfs: return error on non-supported methods
As tarfs is a read-only filesystem backend, we return EROFS (Read-only
file system) from any method that makes modifications.
* tarfs: implement File.data as bytes.Reader
Most of the operations that we want to implement for tarfs.File are
already defined in bytes.Reader.
We could use a plain slice and implement all the seeking manually, but I
think using this is more convenient.
* tarfs: short format for simple methods
* tarfs: add missing closing brace in tests
* tarfs: add test for File.ReadAt
* tarfs: test File.ReadAt
* tarfs: add tests for File.Read
* tarfs: implement File.Read
* tarfs: add tests for File.Seek
* tarfs: implement File.Seek
* tarfs: add tests for File.Name
* tarfs: implement File.Name
* tarfs: add tests for File.Close
* tarfs: implement File.Close
* tarfs: add tests for OpenFile
* tarfs: fix test for Fs.OpenFile
If the call fails, we don't have to close the file
* tarfs: remove code not needed after using filepath.Clean
* tarfs: Open: return a copy of the internal structure
As we modify the struct fields when closing, we don't want to lose the
internal representation of the file, in case we want to reopen it.
Return a copy of the File, although we keep using the same pointers to
tar.Header and buffer.Reader. Maybe we will need to change that in the
future.
* tarfs: implement Fs.OpenFile
* tarfs: use Fatalf for unexpected error in TestFsOpen
* tarfs: add tests for Fs.Stat
* tarfs: implement Fs.Stat
* tarfs: remove TestNewFs
That test depends too much on the internal imlementation, and it is
easier to break if we change it.
* tarfs: remove unused code
* tarfs: change internal implementation
To be able to handle directories (File.Readdir, File.Readdirnames), the
naive single-map implementation makes it a bit harder to implement.
Inspired by the zipfs backend, switch to an internal implementation of a
map of directories that contains a map of files, so the directory
methods are easier to implement.
Also, treat the "virtual" filesystem as absolute, just like zipfs does.
* tarfs: use Fatal errors to avoid panics
* tarfs: add pseudoroot
* tarfs: add tests for File.Readdir
* tarfs: add pointer Fs in the File structure
For directory-related operations we will need to access the internal
structure in the Fs.
As Readdir and Readdirnames are File methods, we need to access such
structure from the File.
* tarfs: fix error
* tarfs: use just the names for TestReaddir, easier than using fill os.FileInfo entries
* tarfs: create a copy of the original entry when opening a file
We added the fs field in the File struct to reference the underlying Fs
object, but in the Open cal we were not passing it, making all the
opened files to have a nil pointer in that field.
Change to make a copy of the original file, and returning that
* tarfs: implement File.Readdir
* tarfs: add tests for File.Readdirnames
* tarfs: implement Readdirnames
* tarfs: add test for File.Name
* tarfs: change tests to use the Afero interface instead
* tarfs: add tests for Glob from zipfs
* tarfs: update main repo references to tarfs
* tarfs: use OS-specific file separator for pseudoroot
* tarfs: fix path handling in Windows systems
To match behavior of os.File.Readdir, argument c in UnionFile.Readdir
should control amount of files read, not the upper bound of buffered
files.
Fixes#259
- "/" should have mode `os.ModeDir|0755`, not `0000`. Among other
things, this had resulted in `mode.IsDir()` returning false for root
prior to this patch.
- `Mkdir`, `MkdirAll`, and `OpenFile` shouldn't be allowed to set
permissions that are otherwise illegal through `Chmod`. This mirrors
what Go's `os` package does: it calls `syscallMode(mode)`, which
effectively clears out the same bits that are disallowed by `Chmod`.
- `MkdirAll` should use the given permissions for all intermediate
directories that are created, not just for the final directory. Prior
to this patch, intermediate directories were created with mode bits
`0000`. Besides the permission bits being wrong, `mode.IsDir()` would
return false for these directories prior to this patch.
Michail Kargakis